Attention is currently required from: ChiaLing, Eric Lai, Ricky Chang, Sheng-Liang Pan, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76246?usp=email )
Change subject: soc/intel/jasperlake: Add configs for USB 3.1 Gen2 EV settings
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76246/comment/58a9ec0e_564362c6 :
PS4, Line 7: EV
What is EV?
https://review.coreboot.org/c/coreboot/+/76246/comment/12718f02_d16df73a :
PS4, Line 15: All usb configs were set correctly.
Without these configs, are the USB3 ports not supporting Gen2 speeds? What is the user visible functional change with these configs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76246?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecd12d3db76b63ad99887dee5991d94d47f138fd
Gerrit-Change-Number: 76246
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ricky Chang
rickytlchang@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chia-Ling Hou
chia-ling.hou@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Attention: Ricky Chang
rickytlchang@google.com
Gerrit-Comment-Date: Tue, 08 Aug 2023 15:54:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment