Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Lean Sheng Tan, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54960 )
Change subject: soc/intel/elkhartlake: Update FSP-S UPD related configs part 2
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54960/comment/645ce846_459e1fb3
PS8, Line 7: part 2
I am not a fan of this, as it does not help a lot, when reading the commit log/history.
Can the changed components be grouped by a word? If not, and possible, I’d do a commit for each item listed below. But if that’s not feasible, maybe one big commit is better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I657f44f8506640c23049614b2db9d1837e6d44ed
Gerrit-Change-Number: 54960
Gerrit-PatchSet: 8
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 28 May 2021 06:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment