Attention is currently required from: Raul Rangel, Bhanu Prakash Maiya, Kenneth Chan, Karthik Ramasubramanian. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61174 )
Change subject: mb/google/guybrush/var/dewatt: Update touchpad GPIO configuration ......................................................................
Patch Set 3: Verified+1
(3 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139102): https://review.coreboot.org/c/coreboot/+/61174/comment/c757a9f2_6b62fd99 PS3, Line 42: /* SOC_TCHPAD_INT_ODL */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139102): https://review.coreboot.org/c/coreboot/+/61174/comment/2a86b8dc_518fd942 PS3, Line 43: PAD_SCI(GPIO_9, PULL_NONE, LEVEL_LOW), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139102): https://review.coreboot.org/c/coreboot/+/61174/comment/04ab0389_d30a2022 PS3, Line 43: PAD_SCI(GPIO_9, PULL_NONE, LEVEL_LOW), please, no spaces at the start of a line