Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 22:
(367 comments)
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6cb7c2e2_ee194f56 PS22, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5611a62f_9e9e2517 PS22, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d947617e_9feb1a5f PS22, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9394f53e_73916696 PS22, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/de3f19d0_31f29963 PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d852b675_d80f0b41 PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4f5ceb37_9d23761d PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9731a0f9_793c1b4e PS22, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8335534_c489b009 PS22, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cec81005_31b5965f PS22, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/bf77d3b5_8b26a909 PS22, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/24a276fc_a1456261 PS22, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ae6088ac_bdcfc1e2 PS22, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6e11891b_b5de7aae PS22, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9e39f74b_b051e015 PS22, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c4c246f3_24056c0f PS22, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e09f3185_9ec1dec6 PS22, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7bf13b4f_b8affbdb PS22, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1f55b15e_d3eb0bdd PS22, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/303dea43_68bf80b6 PS22, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1ded75e3_bc42b4a7 PS22, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e0649b30_dc1f275a PS22, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/79c051ab_1ea9e405 PS22, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/46a88621_657b2935 PS22, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a740a508_eb8eb017 PS22, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7d119a33_a1c720e0 PS22, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/16161fa0_73e61c58 PS22, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8306e8a4_da5f3151 PS22, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7a6d567c_05e48501 PS22, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/58282180_b43b429b PS22, Line 207: trailing whitespace
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa86d9b0_5aaf8d59 PS22, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/25bc01db_3ff3495d PS22, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/50c5e6e1_cc91e198 PS22, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/52b219e5_19f27ca5 PS22, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8ebeb172_a2894d43 PS22, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d3c817f8_ba94e80e PS22, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8877ef57_d1ab5691 PS22, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/24da814e_966fb559 PS22, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a7e86ab3_6e19f7b4 PS22, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/27c07210_e9c0f41a PS22, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/389e5764_c46e5aeb PS22, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f97855d0_d2e88317 PS22, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8843c807_e341e567 PS22, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2552eae8_48b85f46 PS22, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c1f764a1_83b79a96 PS22, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fb894e71_1f0ddf11 PS22, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b529ae68_7cade90a PS22, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3acb3362_52310ba2 PS22, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2567c63e_13c78679 PS22, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4ed6e357_b8092092 PS22, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f25000fa_f44a316b PS22, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/45988adb_1510902b PS22, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cfdbc244_7c897669 PS22, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/07b10fc5_e520a94c PS22, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6c5644ef_c7bc16fe PS22, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c6c7db95_a4be6b01 PS22, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0a92d46c_bf5a9b63 PS22, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/62f265c8_2315f88b PS22, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/038d8201_b792db13 PS22, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9a16de5f_ce22f410 PS22, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8b50507c_11b675a6 PS22, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9f717bf0_245415d7 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0ef02010_f2c1249e PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a2799a39_a4d3f9bf PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c77a9c10_b3922fd2 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3199fc3d_bf5c0eb3 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/695e57d4_0b426394 PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/847a98f0_8f3f86ad PS22, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/99a29a6c_d1f3a961 PS22, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/23a3c36e_d28a9893 PS22, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/00dfd9b3_283e6404 PS22, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/66892804_05c57cee PS22, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9e9e85fd_8c421676 PS22, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8302474e_1445da46 PS22, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3f7db1c9_db3a7fb9 PS22, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/baac9fe9_67daddb3 PS22, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/244b5a71_383670af PS22, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1de37a8c_c36fba01 PS22, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2573e23b_98b920fe PS22, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7733a1bf_3d27e37a PS22, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7f4e92ee_f2ef62c6 PS22, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7891cd40_ed23c0dd PS22, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d826f03c_4626d420 PS22, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/90fe7b7a_49d6033e PS22, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0cefa410_878a3566 PS22, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4c7df651_a0a4d5be PS22, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3c49448f_4c11122e PS22, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/80ad7aad_2fcf7de0 PS22, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f0cc5e3a_f4dd443f PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c70404dc_9e5a6370 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8117f574_711c8612 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/12b7e0d1_1b09f060 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/90171235_e8eeb0e6 PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/867a39a7_c681336b PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/715996cc_d0b180db PS22, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/45f681f7_b58416f6 PS22, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/343d849c_d2dc52de PS22, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9aa92368_5259ca80 PS22, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e27b2f9d_78934c90 PS22, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/31391bf8_5bbcfa23 PS22, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2e6fd692_93bc22f8 PS22, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/267229b7_7d61ea4d PS22, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/96b47869_bfd45800 PS22, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/898caec6_ab6f95b7 PS22, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/abb7d935_d3319018 PS22, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d435783b_ce0bfbef PS22, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7fd5e392_4b37f663 PS22, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/809a778e_5de33b43 PS22, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ca00dd96_820ab3f9 PS22, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/76cac3bd_d08ac5d5 PS22, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/40ac0ed4_3f1a68be PS22, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7ef15ddc_4fe2eb58 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/16fa9693_37bb8817 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c6db919f_337fb576 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/400ba16c_0f8bdda4 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2e94e06c_d9a3d167 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/123c7ebc_635958b7 PS22, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/017d63bd_9d4f32d3 PS22, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/710d566e_f00fc60b PS22, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7ce2c140_dec8a0d1 PS22, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d1c688aa_23184f7e PS22, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8746c982_b6534832 PS22, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/30a2c8c2_9cd55bfc PS22, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b62b0a77_17500e85 PS22, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a9c4e6bc_f1dd8781 PS22, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/de5ef2b6_584d5d65 PS22, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/406e7d0a_3a272bb3 PS22, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0b84d1c3_5dfbc0ba PS22, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f05fd461_ee73b21d PS22, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/565ce981_7dd688a5 PS22, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/90369c36_3d0912a8 PS22, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ff62cba3_0dcc7649 PS22, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/38f352e3_ca3597f3 PS22, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2716183a_9543125e PS22, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7d489106_1987f0f0 PS22, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f8797f18_6adaa4e8 PS22, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/109fd79c_b5970ed4 PS22, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f894d029_26ef7b59 PS22, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a52a6be5_f111dbe0 PS22, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8796b67_122a63fd PS22, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/22a9a492_05603701 PS22, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/89235751_bfd445c9 PS22, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8e3e5eb9_cc58cd45 PS22, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d184328a_fc0f4161 PS22, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aed6364c_905366d8 PS22, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/caa46ed5_dfa855ed PS22, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1f135312_82473cee PS22, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/20efc940_842e2977 PS22, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/50f591b3_73958343 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/82bd6125_79789276 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/60a5f0c7_943b0d46 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/731e9616_555fe30d PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/64ba1cdc_e09f3550 PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5cde61f8_67d375be PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/624ad5c4_0667ad5a PS22, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a10b9735_f4b98cad PS22, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/67023810_9d5bd812 PS22, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fe896e52_2fa44831 PS22, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fc0273df_afcd9d2a PS22, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a296526a_fec9be2b PS22, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a6c34c43_107c6522 PS22, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/67f9ec56_0a668f66 PS22, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1e94025e_58c3abcd PS22, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/61c8b0d4_56d2b72c PS22, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/377836af_8468a375 PS22, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a7598e27_32613a28 PS22, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1b5429c3_9b946380 PS22, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3accc7c0_dc616e44 PS22, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d2f4cbb1_d1e4e29d PS22, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4ad36c86_0d6c6835 PS22, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ee60b83e_95130d10 PS22, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/006a8f82_22b86344 PS22, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fca4c753_b4da7ae6 PS22, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/30709847_b7f14fe3 PS22, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/51c8352a_157cf027 PS22, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ee360b7c_17d89b0e PS22, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6ce066ff_17178bb5 PS22, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f495bba7_9a4eb0e5 PS22, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d5f29e32_368f9a7a PS22, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4f6abd6e_430a0043 PS22, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/530d4763_d0185237 PS22, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6a46e8b5_eacf9b70 PS22, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/13a85f6f_7492043e PS22, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/734a6681_26c7bff4 PS22, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d39efa85_5c93d78f PS22, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/52be45bc_f77f012e PS22, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/156ae69a_650fc406 PS22, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/efecd286_0480acf3 PS22, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f6f22cff_c3be3f63 PS22, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b8b76e80_665783a1 PS22, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0b39ad89_c09531dc PS22, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4865ac0c_79aad257 PS22, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/92eeaee9_21a8700b PS22, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3d9588bd_32629e36 PS22, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8fa87d5_715131f5 PS22, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aada2970_aa70d04f PS22, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/10e75339_7f957fac PS22, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/de735d42_1a902abc PS22, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9fc5d675_8a25a3ae PS22, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/bdf6d0d1_92cd520d PS22, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5a9e3e9f_a3b76151 PS22, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d07a19e6_c01cd426 PS22, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5add8303_e2cd80a0 PS22, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4158e550_ee793ec5 PS22, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/47e832ea_0e9f3f85 PS22, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6311733c_3bc974d1 PS22, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d8a2bd4a_34a769de PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/980fe33a_0fa4f213 PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3c9b665f_ec994d44 PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f051c46c_6ee001dc PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/81ed0db4_37dac4bb PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8de60848_d99df82a PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/af577613_43718e6b PS22, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ede1937b_f00f75ef PS22, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e6426034_bb939b3a PS22, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa9aa281_fa3e06cc PS22, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e40aca46_7ba32879 PS22, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3d23f9c0_fe6cb23a PS22, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/25ac6483_c0251f88 PS22, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/10764a59_a8098d85 PS22, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/20076911_f48ca35a PS22, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/41bb33a4_643b8326 PS22, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6af5a4b8_9b2386c8 PS22, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/76c8fe8d_6d6ae9d7 PS22, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6cfdf1a8_0ab2fed1 PS22, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ad25efe6_f5021cbc PS22, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2acb367b_6899b68f PS22, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/956b4036_cea71822 PS22, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b9c8cb8b_6e7a0a93 PS22, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/06f0ed6e_faf9b764 PS22, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/17c817bc_01f5d029 PS22, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ae6eb857_b2cd758e PS22, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9f58c0ad_8f6eb9f2 PS22, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/76536a83_1c6e6b7a PS22, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8d5b1b8c_f1cdfff3 PS22, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9422a393_6224105c PS22, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ffbacbd3_f1511782 PS22, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a309c34e_33d65aac PS22, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/83ae6f8b_f0eecc7e PS22, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/47242016_158f8000 PS22, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/343f25e4_4ef47b80 PS22, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cbba1c9d_3b67d738 PS22, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/926e56d2_519eefb8 PS22, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/09f8b12b_20615758 PS22, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/eb07d3f9_9e702fc7 PS22, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5908262f_155c24d9 PS22, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2579760e_356f76b3 PS22, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/abed3c4f_a7089520 PS22, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b12152b6_6cd77d4c PS22, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d960060f_8fe5706b PS22, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4147cce6_aeb560e3 PS22, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8a577484_e3367c1e PS22, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ab3b0b99_95ab89cb PS22, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/425d1816_60f4af63 PS22, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5db34f14_412119e9 PS22, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/85a613d7_7d89302b PS22, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2a18f1df_21c13cdd PS22, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3a646683_2e8fdaa2 PS22, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/922e8157_8e74afe5 PS22, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/08a8b55a_c3da5866 PS22, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7a98a135_3d4a2ddf PS22, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/1525831b_e6c542e6 PS22, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d18d34a6_0ac7c7cc PS22, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9ffc0a00_f6ad48c9 PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/93556f8e_1a71576e PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/717e2773_2201449e PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a5dc8e47_feea0e6b PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/36b65d7b_7de2e6d1 PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d68798ae_fe8c27bb PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/57909029_40be56a3 PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0f006828_75876a8b PS22, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/227f67ba_8ba37a9e PS22, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b276ebfe_232ba24f PS22, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3aef7f61_36b54170 PS22, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4eb66885_7e914dde PS22, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e89abf05_1e3543e5 PS22, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e6c91cca_71cdf612 PS22, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/287f0058_569bc052 PS22, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/5878d837_8a7f5f69 PS22, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4f6b0d81_c75d5e18 PS22, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9a637661_fac7b6d8 PS22, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/57a4e5f7_bed6abc1 PS22, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8e5d0169_fb77b3ba PS22, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0553b5d1_a2edda5f PS22, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/74564100_6c5ba489 PS22, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7ed3ef66_876113b8 PS22, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/18830fd1_2c173f23 PS22, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9b097df7_0600c221 PS22, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f2787934_481a7095 PS22, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/57530f72_24c9400b PS22, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa05e6c2_c3ae2dd3 PS22, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/032efddc_19d59fc5 PS22, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c1f73913_1f84ef42 PS22, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ac98b157_6e8d6430 PS22, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/2ced70f7_50cf9652 PS22, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b6f60b26_bee78d0b PS22, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/39e991f5_ceb37ca7 PS22, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/429e7f5c_97f16825 PS22, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/95b321ff_3a418a53 PS22, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/083b7448_56b300df PS22, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b67d88dc_4ab68af4 PS22, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6f0e3b03_e3fc8a66 PS22, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a1d47d64_20dc4155 PS22, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f4511b5d_9fafca2d PS22, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/008e8a38_95095ce1 PS22, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/15942c6c_7e6ae145 PS22, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d9779e40_c3e7cf0e PS22, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3ffd7b6f_cc266adf PS22, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6daba129_9ab117b6 PS22, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ec5bcf94_3f3963fc PS22, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0361ff3a_69940544 PS22, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ff27d295_8ebf3623 PS22, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e852d69a_3d29f249 PS22, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/01f9f3d7_70b4da11 PS22, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/448d1d1e_ccbd45cb PS22, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/8f3285c0_19258c36 PS22, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e70515a9_69ab042f PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a18133fa_6368dd6e PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3192e57d_c82f3d6a PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f2868817_5f709850 PS22, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/09e67cf1_149e1660 PS22, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/31a4b327_f25a3f36 PS22, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/30ad5d77_38a855fe PS22, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c8844996_98efeeab PS22, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/402d6d23_dbb9b760 PS22, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a287d94d_64ec4ea3 PS22, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ecfcc627_0778fb79 PS22, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3cefab4c_6f54c121 PS22, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/16ebbe40_2dbc24d3 PS22, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/3b07e088_55a992ba PS22, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/345e3d59_29093c83 PS22, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/9f8bae2b_26ebcaaa PS22, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/aa6058cb_231da4a9 PS22, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/42ca19a6_71283349 PS22, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d8f5a4be_d41a6e76 PS22, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c5094385_cc140064 PS22, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/61ccaca7_8d6fca2e PS22, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/46fc1a00_3d79dfc7 PS22, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/a1c73a32_4564d836 PS22, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/febd3c21_db4bce32 PS22, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/93ec428e_f5eeeb71 PS22, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/e78b6e75_2f80771d PS22, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/548af53e_0528fe9e PS22, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/4e359f96_fa8da887 PS22, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c2b858bc_6504a9f8 PS22, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7cd77bbb_3c051f38 PS22, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/96cb177e_85b078d7 PS22, Line 188: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/toggleswitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/932caaac_708eb46d PS22, Line 9: /// \brief The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/b98a12ef_9eae8e86 PS22, Line 12: Q_OBJECT please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ace3f3bb_36048771 PS22, Line 13: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/fa012e9a_5f4abab1 PS22, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/cf46e4e7_976d324c PS22, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0333ad9f_55830503 PS22, Line 17: QSvgRenderer m_svgr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f5e6bdf6_313d282f PS22, Line 19: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/c400bf89_9447c104 PS22, Line 20: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/d4f790a7_5fc39e19 PS22, Line 22: void recolorToggleOn(const QPalette& palette); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/0f97bd4a_7179d9f2 PS22, Line 22: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f402fc12_4e9cb4fd PS22, Line 23: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/58b14b33_590d1b09 PS22, Line 27: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7cbc20b5_6617432f PS22, Line 27: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/6d67fbe3_9096d0e8 PS22, Line 31: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/f17271ac_2e9a7026 PS22, Line 31: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/72aebc4a_8e386c85 PS22, Line 32: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/ebce79d6_e3f98e10 PS22, Line 33: //needs to be clickable on code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/04024376_92766e75 PS22, Line 34: return rect().contains(pos); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/7efad0de_f8e0d2df PS22, Line 34: return rect().contains(pos); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132348): https://review.coreboot.org/c/coreboot/+/58854/comment/33b03798_efbe50cf PS22, Line 35: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)