Attention is currently required from: Marc Jones, Furquan Shaikh, Duncan Laurie, David Hendricks, Angel Pons, Rocky Phagura.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49286 )
Change subject: src/acpi: Add APEI EINJ support
......................................................................
Patch Set 12: Code-Review+2
(2 comments)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/49286/comment/9a898325_f2f59af7
PS11, Line 993:
I haven't been able to test anything with this, but I'm hoping others can add it once they need it. […]
Ack
https://review.coreboot.org/c/coreboot/+/49286/comment/d0ca895c_e2edc8e0
PS11, Line 1001: /* EINJ (Error Injection Table) */
: typedef struct acpi_gen_regaddr1 {
: u8 space_id; /* Address space ID */
: u8 bit_width; /* Register size in bits */
: u8 bit_offset; /* Register bit offset */
: u8 access_size; /* Access size since ACPI 2.0c */
: u64 addr; /* Register address */
: } __packed acpi_addr64_t;
:
Yes, that's correct but it matches the ACPI spec. The same comment as above applies here. […]
It depends on architecture endianness (obviously x86 this is fine)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29c6a861c564ec104f2c097f3e49b3e6d38b040e
Gerrit-Change-Number: 49286
Gerrit-PatchSet: 12
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Duncan Laurie
duncan@iceblink.org
Gerrit-Attention: David Hendricks
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Rocky Phagura
Gerrit-Comment-Date: Thu, 29 Apr 2021 22:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Rocky Phagura
Gerrit-MessageType: comment