Attention is currently required from: Felix Singer, Erik van den Bogaert, Michał Żygowski, Frans Hendriks, Michael Niewöhner, Patrick Rudolph, Piotr Król. Hello Felix Singer, Erik van den Bogaert, Michał Żygowski, Frans Hendriks, Michael Niewöhner, Patrick Rudolph, Piotr Król,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60722
to look at the new patch set (#2).
Change subject: soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config ......................................................................
soc/intel/skl: Replace dt `HeciEnabled` by `CSE disable` config
Lists of changes:
1. Drop `HeciEnabled` from dt and dt chip configuration. 2. Replace all logic that disables CSE based on the `HeciEnabled` chip config with `DISABLE_CSE_AT_PRE_BOOT` config. 3. Make dt CSE PCI device `on` by default. 4. Mainboards selects DISABLE_CSE_AT_PRE_BOOT config to make CSE function disable at pre-boot instead of the dt policy that uses `HeciEnabled = 0`.
Mainboards that choose to make CSE enable during boot don't select `cse disable` config.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I5c13fe4a78be44403a81c28b1676aecc26c58607 --- M src/mainboard/51nb/x210/devicetree.cb M src/mainboard/asrock/h110m/Kconfig M src/mainboard/asrock/h110m/devicetree.cb M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb M src/mainboard/facebook/monolith/Kconfig M src/mainboard/facebook/monolith/devicetree.cb M src/mainboard/google/eve/Kconfig M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/fizz/Kconfig M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/intel/kblrvp/Kconfig M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/kunimitsu/devicetree.cb M src/mainboard/libretrend/lt1000/devicetree.cb M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/purism/librem_skl/devicetree.cb M src/mainboard/razer/blade_stealth_kbl/devicetree.cb M src/soc/intel/skylake/chip.c M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/finalize.c 32 files changed, 15 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/60722/2