Change in coreboot[master]: cpu/intel: Make doubly sure we don't write to IA32_FEATURE_CTRL if it... - coreboot-gerrit

5 Sep 2021


      Attention is currently required from: Darius Goad, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57089 )
Change subject: cpu/intel: Make doubly sure we don't write to IA32_FEATURE_CTRL if its lock bit is set on a reset.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1: 
Um, the `set_feature_ctrl_vmx()` function already makes sure that the IA32_FEATURE_CTRL doesn't get written to if locked. What does this change accomplish?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6ff08b6997e5662d32ff003a436c62ccc1c40ac
Gerrit-Change-Number: 57089
Gerrit-PatchSet: 1
Gerrit-Owner: Darius Goad
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Darius Goad
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:38:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment