Attention is currently required from: Elyes Haouas.
Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/69066?usp=email )
Change subject: mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn) ......................................................................
Patch Set 9:
(14 comments)
File src/mainboard/asus/p2b/variants/p2b/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/69066/comment/f37ff93f_e4eb5e04?usp... : PS9, Line 21: {0x00,PCI_DEVFN(0x0c, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x1, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/001c8f38_b4665cb2?usp... : PS9, Line 22: {0x00,PCI_DEVFN(0x0b, 0), {{0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x01eb8}}, 0x2, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/3dda27aa_ce28f719?usp... : PS9, Line 23: {0x00,PCI_DEVFN(0x0a, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x3, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/ce578de3_d7839602?usp... : PS9, Line 24: {0x00,PCI_DEVFN(0x09, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x4, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/a9a10c69_e580f3b2?usp... : PS9, Line 25: {0x00,PCI_DEVFN(0x04, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/986e23e6_62d42a24?usp... : PS9, Line 26: {0x00,PCI_DEVFN(0x01, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
File src/mainboard/asus/p2b/variants/p3b-f/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/69066/comment/eefc2bce_c7735d3f?usp... : PS9, Line 21: {0x00,PCI_DEVFN(0x0c, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x1, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/6b0fcd87_e3c6f932?usp... : PS9, Line 22: {0x00,PCI_DEVFN(0x0b, 0), {{0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x01eb8}}, 0x2, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/a9ad5a5a_dbf01993?usp... : PS9, Line 23: {0x00,PCI_DEVFN(0x0a, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x3, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/ac3db0a7_589a47df?usp... : PS9, Line 24: {0x00,PCI_DEVFN(0x09, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x4, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/a4f8b5cf_a4d11e64?usp... : PS9, Line 25: {0x00,PCI_DEVFN(0x0d, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x5, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/4e2df0e0_061bdb0f?usp... : PS9, Line 26: {0x00,PCI_DEVFN(0x0e, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x6, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/38291d2d_3c4bb539?usp... : PS9, Line 27: {0x00,PCI_DEVFN(0x04, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
https://review.coreboot.org/c/coreboot/+/69066/comment/5e0d381d_14e8b790?usp... : PS9, Line 28: {0x00,PCI_DEVFN(0x01, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
`space required after that ',' (ctx:VxV)` […]
Done
-
Maximilian Brune (Code Review)