Change in ...coreboot[master]: soc/amd/common: Remove AmdReadEventLog() - coreboot-gerrit

19 Feb 2019

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31484
Change subject: soc/amd/common: Remove AmdReadEventLog()
......................................................................
soc/amd/common: Remove AmdReadEventLog()
Parameter passing is incorrect here, it should pass
complete StdHeader instead of attempting to fill
in HeapStatus that should be treated as a field private
to AGESA, based on where it is defined in the header
files.
Furthermore the while() loop did not evaluate the
return value. Feature can be brought back at a later
date after someone verifies it actually works correctly
across different stages.
Change-Id: Ib243b275f8700ecaeb330772c795d305c61899c5
Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com
---
M src/soc/amd/common/block/pi/agesawrapper.c
M src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
2 files changed, 0 insertions(+), 72 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/31484/1

diff --git a/src/soc/amd/common/block/pi/agesawrapper.c b/src/soc/amd/common/block/pi/agesawrapper.c
index 1726955..fb33f4d 100644
--- a/src/soc/amd/common/block/pi/agesawrapper.c
+++ b/src/soc/amd/common/block/pi/agesawrapper.c
@@ -42,34 +42,6 @@
 static void *AcpiIvrs;
 static void *AcpiCrat;
-static AGESA_STATUS agesawrapper_readeventlog(uint8_t HeapStatus)
-{
-	AGESA_STATUS Status;
-	EVENT_PARAMS AmdEventParams = {
-		.StdHeader.CalloutPtr = &GetBiosCallout,
-		.StdHeader.HeapStatus = HeapStatus,
-	};
-
-	Status = AmdReadEventLog(&AmdEventParams);
-	if (AmdEventParams.EventClass)
-		printk(BIOS_DEBUG, "AGESA Event Log:\n");
-
-	while (AmdEventParams.EventClass != 0) {
-		printk(BIOS_DEBUG, "  Class = %x, Info = %x,"
-				" Param1 = 0x%x, Param2 = 0x%x"
-				" Param3 = 0x%x, Param4 = 0x%x\n",
-				(u32)AmdEventParams.EventClass,
-				(u32)AmdEventParams.EventInfo,
-				(u32)AmdEventParams.DataParam1,
-				(u32)AmdEventParams.DataParam2,
-				(u32)AmdEventParams.DataParam3,
-				(u32)AmdEventParams.DataParam4);
-		Status = AmdReadEventLog(&AmdEventParams);
-	}
-
-	return Status;
-}
-
 static void *create_struct(AMD_INTERFACE_PARAMS *interface_struct)
 {
    /* Should clone entire StdHeader here. */
@@ -108,8 +80,6 @@
    status = AmdInitReset(ResetParams);
    timestamp_add_now(TS_AGESA_INIT_RESET_DONE);
-	if (status != AGESA_SUCCESS)
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
    AmdReleaseStruct(&AmdParamStruct);
    return status;
 }
@@ -131,8 +101,6 @@
    status = AmdInitEarly(EarlyParams);
    timestamp_add_now(TS_AGESA_INIT_EARLY_DONE);
-	if (status != AGESA_SUCCESS)
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
    AmdReleaseStruct(&AmdParamStruct);
return status;
@@ -219,8 +187,6 @@
print_init_post_settings(PostParams);
-	if (status != AGESA_SUCCESS)
-		agesawrapper_readeventlog(PostParams->StdHeader.HeapStatus);
    AmdReleaseStruct(&AmdParamStruct);
return status;
@@ -243,8 +209,6 @@
    status = AmdInitEnv(EnvParams);
    timestamp_add_now(TS_AGESA_INIT_ENV_DONE);
-	if (status != AGESA_SUCCESS)
-		agesawrapper_readeventlog(EnvParams->StdHeader.HeapStatus);
    AmdReleaseStruct(&AmdParamStruct);
return status;
@@ -296,8 +260,6 @@
    status = AmdInitMid(MidParams);
    timestamp_add_now(TS_AGESA_INIT_MID_DONE);
-	if (status != AGESA_SUCCESS)
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
    AmdReleaseStruct(&AmdParamStruct);
return status;
@@ -328,11 +290,6 @@
    Status = AmdInitLate(LateParams);
    timestamp_add_now(TS_AGESA_INIT_LATE_DONE);
-	if (Status != AGESA_SUCCESS) {
-		agesawrapper_readeventlog(LateParams->StdHeader.HeapStatus);
-		ASSERT(Status == AGESA_SUCCESS);
-	}
-
    DmiTable = LateParams->DmiTable;
    AcpiPstate = LateParams->AcpiPState;
@@ -372,11 +329,6 @@
    Status = AmdInitRtb(RtbParams);
    timestamp_add_now(TS_AGESA_INIT_RTB_DONE);
-	if (Status != AGESA_SUCCESS) {
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
-		ASSERT(Status == AGESA_SUCCESS);
-	}
-
    if (save_s3_info(RtbParams->S3DataBlock.NvStorage,
    		 RtbParams->S3DataBlock.NvStorageSize,
    		 RtbParams->S3DataBlock.VolatileStorage,
@@ -406,8 +358,6 @@
    status = AmdInitResume(InitResumeParams);
    timestamp_add_now(TS_AGESA_INIT_RESUME_DONE);
-	if (status != AGESA_SUCCESS)
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
    AmdReleaseStruct(&AmdParamStruct);
return status;
@@ -436,10 +386,6 @@
    Status = AmdS3LateRestore(S3LateParams);
    timestamp_add_now(TS_AGESA_S3_LATE_DONE);
-	if (Status != AGESA_SUCCESS) {
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
-		ASSERT(Status == AGESA_SUCCESS);
-	}
    AmdReleaseStruct(&AmdParamStruct);
return Status;
@@ -466,10 +412,6 @@
    Status = AmdS3FinalRestore(S3FinalParams);
    timestamp_add_now(TS_AGESA_S3_FINAL_DONE);
-	if (Status != AGESA_SUCCESS) {
-		agesawrapper_readeventlog(AmdParamStruct.StdHeader.HeapStatus);
-		ASSERT(Status == AGESA_SUCCESS);
-	}
    AmdReleaseStruct(&AmdParamStruct);
return Status;
diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index c42df59..2efee4e 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -226,17 +226,3 @@
    if (!Dispatcher) return AGESA_UNSUPPORTED;
    return Dispatcher(AmdApExeParams);
 }
-
-/**********************************************************************
- * Interface service call:  AmdReadEventLog
- **********************************************************************/
-AGESA_STATUS
-AmdReadEventLog (
-  IN       EVENT_PARAMS *Event
-)
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	Event->StdHeader.Func = AMD_READ_EVENT_LOG;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(Event);
-}
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31484
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib243b275f8700ecaeb330772c795d305c61899c5
Gerrit-Change-Number: 31484
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: newchange



    