Attention is currently required from: Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55764 )
Change subject: cbfstool: Unset ${DEBUG} when making vboot hostlib ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55764/comment/9cb49e50_c75502cd PS1, Line 13: fail due to calls to vb2api_fail() which is not built in.
My bad. The error is not when building the lib but when trying to link with it.
Okay, sorry, figured it out. The DEBUG=1 disables optimization and causes it to emit code for a
if (<something that's compile-time guaranteed to be false in this case>) vb2api_fail();
that's generated by a macro. Should probably fix that, or just get rid of the DEBUG thing entirely.
Anyway, this patch looks good.