Change in coreboot[master]: mainboard/puff: Tune ALC5682I rise_fall times on i2c

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Edward O'Callaghan (Code Review)

17 Jan 2020 17 Jan '20

8:48 a.m.

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

mainboard/puff: Tune ALC5682I rise_fall times on i2c

Tunes the headphone amp i2c with measured signal shape.

BUG=b:147192377 BRANCH=none TEST=builds

Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38459/1

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index e3ccc61..e23dc90 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -107,8 +107,8 @@ }, .i2c[4] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 0, - .fall_time_ns = 0, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

17 Jan 17 Jan

8:57 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38459/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38459/1//COMMIT_MSG@13 PS1, Line 13: builds Frequency measured is below 400kHz?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 Jan 2020 07:57:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:17 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 Jan 2020 10:17:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Daniel Kurtz (Code Review)

20 Jan 20 Jan

1:29 a.m.

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 1: Code-Review+1

+2 modulo pending TEST= update per Furquan's feedback.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jan 2020 00:29:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Chen (Code Review)

14 Apr 14 Apr

9:08 a.m.

Tim Chen has uploaded a new patch set (#2) to the change originally created by Edward O'Callaghan. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

mainboard/puff: Tune ALC5682I rise_fall times on i2c

Tunes the headphone amp i2c with measured signal shape.

BUG=b:147192377 BRANCH=none TEST=builds and measured i2c frequency below 400khz

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/38459/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Chen (Code Review)

9:09 a.m.

Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38459/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38459/1//COMMIT_MSG@13 PS1, Line 13: builds

...

Frequency measured is below 400kHz?

from b:147192377 #6's result, yes it is below 400khz

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Tue, 14 Apr 2020 07:09:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Chen (Code Review)

15 Apr 15 Apr

4:03 a.m.

Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 3:

Hi Furquan and Daniel, Could you help to +2 for this CL?

Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Apr 2020 02:03:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:05 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Apr 2020 02:05:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

4:29 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Apr 2020 02:29:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Daniel Kurtz (Code Review)

4:31 a.m.

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Apr 2020 02:31:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

4:34 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38459/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38459/1//COMMIT_MSG@13 PS1, Line 13: builds

...

from b:147192377 #6's result, yes it is below 400khz

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Apr 2020 02:34:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

4:35 a.m.

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

mainboard/puff: Tune ALC5682I rise_fall times on i2c

Tunes the headphone amp i2c with measured signal shape.

BUG=b:147192377 BRANCH=none TEST=builds and measured i2c frequency below 400khz

Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38459 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Daniel Kurtz djkurtz@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Daniel Kurtz: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index bf9120a..3507e6d 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -161,8 +161,8 @@ }, .i2c[4] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 0, - .fall_time_ns = 0, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-MessageType: merged

9elements QA (Code Review)

4:50 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38459 )

Change subject: mainboard/puff: Tune ALC5682I rise_fall times on i2c ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2322 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2321 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2320

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60f73bcf60ed140f595c953be371b982a63f7b95 Gerrit-Change-Number: 38459 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Apr 2020 02:50:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1845

days inactive

1934

days old

coreboot-gerrit@coreboot.org

12 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Daniel Kurtz (Code Review)
Edward O'Callaghan (Code Review)
Furquan Shaikh (Code Review)
Paul Menzel (Code Review)
Tim Chen (Code Review)