Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64659 )
Change subject: soc/mediatek/mt8186: Enable thermal hardware reset ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
This feature is not enabled on MT8173/MT819x. […]
This feauture will not influence the thermal control because this thermal hardware reset is only triggered if we disable thermal throttle policy. Therefore, we think it's not a normal situation to trigger thermal hardware reset.
This feature is only for new hardware structure for thermal. Therefore, we only need to take care for MT8192/MT8195/MT8186.
File src/soc/mediatek/common/include/soc/wdt.h:
https://review.coreboot.org/c/coreboot/+/64659/comment/b4729462_589e2cf2 PS2, Line 19: wdt_reg_irq
According to the datasheet, it should be wdt_req_irq_en.
Done
-
Rex-BC Chen (Code Review)