Change in coreboot[master]: [UNTESTED] intel/stm: Drop now unneeded `num_cpus` param

[Nico Huber (Code Review)]

Hello Kyösti Mälkki, Aaron Durbin, Arthur Heymans, [e-mail],

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/38766

to review the following change.

Change subject: [UNTESTED] intel/stm: Drop now unneeded `num_cpus` param
......................................................................

[UNTESTED] intel/stm: Drop now unneeded `num_cpus` param

Change-Id: I3b4b15af8790b747d9ca9b0ea1cd56f7bc659f0b
Signed-off-by: Nico Huber 
---
M src/cpu/x86/mp_init.c
M src/security/intel/stm/SmmStm.h
M src/security/intel/stm/StmPlatformSmm.c
3 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/38766/1

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index c747207..9bc4aab 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -753,7 +753,7 @@
    		mseg = mp_state.perm_smbase +
    			(mp_state.perm_smsize - CONFIG_MSEG_SIZE);

-			stm_setup(mseg, p->cpu, runtime->num_cpus,
+			stm_setup(mseg, p->cpu,
    				perm_smbase,
    				mp_state.perm_smbase,
    				runtime->start32_offset);
diff --git a/src/security/intel/stm/SmmStm.h b/src/security/intel/stm/SmmStm.h
index 4f72816..1690255 100644
--- a/src/security/intel/stm/SmmStm.h
+++ b/src/security/intel/stm/SmmStm.h
@@ -28,7 +28,7 @@
 int load_stm_image(uintptr_t mseg);

void stm_setup(
-	uintptr_t mseg, int cpu, int num_cpus, uintptr_t smbase,
+	uintptr_t mseg, int cpu, uintptr_t smbase,
    uintptr_t smbase_base, uint32_t offset32);

/*
diff --git a/src/security/intel/stm/StmPlatformSmm.c b/src/security/intel/stm/StmPlatformSmm.c
index eb69301..5be6ee7 100644
--- a/src/security/intel/stm/StmPlatformSmm.c
+++ b/src/security/intel/stm/StmPlatformSmm.c
@@ -154,14 +154,14 @@

static int stm_load_status = 0;

-void stm_setup(uintptr_t mseg, int cpu, int num_cpus, uintptr_t smbase,
+void stm_setup(uintptr_t mseg, int cpu, uintptr_t smbase,
    		uintptr_t base_smbase, uint32_t offset32)
 {
    msr_t InitMseg;
    msr_t MsegChk;
    uintptr_t addr_calc;  // used to calculate the stm resource heap area

-	printk(BIOS_DEBUG, "STM: set up for cpu %d/%d\n", cpu, num_cpus);
+	printk(BIOS_DEBUG, "STM: set up for cpu %d\n", cpu);
    if (cpu == 0) {

// need to create the BIOS resource list once

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38766 )

Change subject: [UNTESTED] intel/stm: Drop now unneeded `num_cpus` param
......................................................................

Patch Set 1: Code-Review+1

Tested with no issues.

Note: 38763 must be applied first.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38766 )

Change subject: [UNTESTED] intel/stm: Drop now unneeded `num_cpus` param
......................................................................

Patch Set 1:

I've just realized that the code is accessing `mp_state` directly,
later to read the CPU count... we should discuss which way is
preferred.

[XS] Change in coreboot[master]: [UNTESTED] intel/stm: Drop now unneeded `num_cpus` param

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38766?usp=email )

Change subject: [UNTESTED] intel/stm: Drop now unneeded `num_cpus` param
......................................................................

Abandoned