Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35602 )
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
arch/x86: Create preprocessed __ROMCC__ bootblock source
Output file is used only as a debugging aid.
Change-Id: Iea9e1a66409659b47dfa3945c63fa1a7874de1ca Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/x86/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35602/1
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 612424d..055911c 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -163,6 +163,8 @@ @printf " ROMCC $(subst $(obj)/,,$(@))\n" $(CC_bootblock) -D__ROMCC__ -D__PRE_RAM__ -D__BOOTBLOCK__ $(CPPFLAGS_bootblock) -MM -MT$(objgenerated)/bootblock.inc \ $< > $(objgenerated)/bootblock.inc.d + $(CC_bootblock) -D__ROMCC__ -D__PRE_RAM__ -D__BOOTBLOCK__ $(CPPFLAGS_bootblock) -E \ + $< > $(objgenerated)/bootblock_romcc.c $(ROMCC) -c -S $(bootblock_romccflags) -I. $(CPPFLAGS_bootblock) $< -o $@
# bootblock.ld is part of $(bootblock-objs)
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35602 )
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35602/2/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35602/2/src/arch/x86/Makefile.inc@1... PS2, Line 167: > -E -o filename works as well, and might have advantages wrt atomic updates (not sure).
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35602
to look at the new patch set (#3).
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
arch/x86: Create preprocessed __ROMCC__ bootblock source
Output file is used only as a debugging aid.
Change-Id: Iea9e1a66409659b47dfa3945c63fa1a7874de1ca Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/x86/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35602/3
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35602 )
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35602/2/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35602/2/src/arch/x86/Makefile.inc@1... PS2, Line 167: >
-E -o filename works as well, and might have advantages wrt atomic updates (not sure).
Done
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35602 )
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35602 )
Change subject: arch/x86: Create preprocessed __ROMCC__ bootblock source ......................................................................
arch/x86: Create preprocessed __ROMCC__ bootblock source
Output file is used only as a debugging aid.
Change-Id: Iea9e1a66409659b47dfa3945c63fa1a7874de1ca Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35602 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 447fd57..c15971f 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -167,6 +167,8 @@ @printf " ROMCC $(subst $(obj)/,,$(@))\n" $(CC_bootblock) -D__ROMCC__ -D__PRE_RAM__ -D__BOOTBLOCK__ $(CPPFLAGS_bootblock) -MM -MT$(objgenerated)/bootblock.inc \ $< > $(objgenerated)/bootblock.inc.d + $(CC_bootblock) -D__ROMCC__ -D__PRE_RAM__ -D__BOOTBLOCK__ $(CPPFLAGS_bootblock) -E \ + $< -o $(objgenerated)/bootblock_romcc.c $(ROMCC) -c -S $(bootblock_romccflags) -I. $(CPPFLAGS_bootblock) $< -o $@
# bootblock.ld is part of $(bootblock-objs)