Attention is currently required from: Julius Werner. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63285 )
Change subject: Factor TI50/CR50 config ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hmmm... okay, let's step back for a moment and try to look at the big picture. […]
It is worth a try, but it will be an involved refactoring.
Currently, I see both CRB_TPM and MAINBOARD_HAS_CRB_TPM in Kconfig. I am not sure how they are used differently, maybe the latter declares that the support exist, and the former can be used to actually enable it in coreboot. I support NO_TPM/TPM1/TPM2 could be used to declare whether we want to use the feature, and supersede CRB_TPM.
As I see it, I would end up with the following Kconfigs:
SPI_TPM I2C_TPM CRB_TPM LPC_TPM
TPM_ATMEL TPM_GOOGLE_CR50 TPM_GOOGLE_TI50 TPM_GENERIC (maybe absence of any of the above implies this)
MAINBOARD_HAS_TPM1 MAINBOARD_HAS_TPM2
The below are the ones which it makes sense for an end-user of a particular board to modify, they take their default from the above two: TPM1 TPM2 NO_TPM
It will be a major refactoring, and I an worried that it will be hard for me to verify that I am not accidentally changing something unintended for an existing board.
-
Jes Klinke (Code Review)