Attention is currently required from: Peter Stuge, Julius Werner, Martin Roth, ron minnich.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70158 )
Change subject: coreboot_tables: Make existing alignment conventions more explicit
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/70158/comment/60fc59f9_f97de2f0
PS2, Line 209: uint8_t pad[2];
: };
:
Will padding work without structure packing?
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/70158/comment/1c8c2501_b2bcc22b
PS2, Line 80: assert(IS_ALIGNED(rec->size, LB_ENTRY_ALIGN));
Without packing on proper size alignment it will fail very often. Many entries do not have their size aligned properly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeef29ef255047a855066469e03b5481812e5975
Gerrit-Change-Number: 70158
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Peter Stuge
peter@stuge.se
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Peter Stuge
peter@stuge.se
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 07:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment