Change in coreboot[master]: mb/google/dedede/var/metaknight: Turn off lte power when s0ix

[David Wu (Code Review)]

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55249 )

Change subject: mb/google/dedede/var/metaknight: Turn off lte power when s0ix
......................................................................

mb/google/dedede/var/metaknight: Turn off lte power when s0ix

Turn off lte power when s0ix for power saving.

BUG=b:188614547
TEST= measure lte power comsumption is 0mV under s0ix

Change-Id: I78a39d8cd7a348ad36be9b5969f5c75ed48df833
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/dedede/dsdt.asl
A src/mainboard/google/dedede/variants/metaknight/include/variant/acpi/lte.asl
4 files changed, 27 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/55249/1

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig
index e1bc9ad..3e68e9b 100644
--- a/src/mainboard/google/dedede/Kconfig
+++ b/src/mainboard/google/dedede/Kconfig
@@ -149,6 +149,12 @@
    default "pirika" if BOARD_GOOGLE_PIRIKA
    default "haboki" if BOARD_GOOGLE_HABOKI

+config VARIANT_HAS_LTE_ACPI
+	bool
+	default n
+	help
+	  Select this option to enable lte ACPI support on the variant.
+
 endif #BOARD_GOOGLE_BASEBOARD_DEDEDE

if BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index 3f2c522..0d558c1 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -91,6 +91,7 @@
    bool "-> Metaknight"
    select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50
    select BASEBOARD_DEDEDE_LAPTOP
+	select VARIANT_HAS_LTE_ACPI

config BOARD_GOOGLE_LANTIS
    bool "-> Lantis"
diff --git a/src/mainboard/google/dedede/dsdt.asl b/src/mainboard/google/dedede/dsdt.asl
index f88e2df..344fda7 100644
--- a/src/mainboard/google/dedede/dsdt.asl
+++ b/src/mainboard/google/dedede/dsdt.asl
@@ -35,6 +35,11 @@
    #include <variant/acpi/camera.asl>
 #endif

+#if CONFIG(VARIANT_HAS_LTE_ACPI)
+	/* LTE */
+	#include <variant/acpi/lte.asl>
+#endif
+
    #include <southbridge/intel/common/acpi/sleepstates.asl>

/* Chrome OS Embedded Controller */
diff --git a/src/mainboard/google/dedede/variants/metaknight/include/variant/acpi/lte.asl b/src/mainboard/google/dedede/variants/metaknight/include/variant/acpi/lte.asl
new file mode 100644
index 0000000..1e76e17
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/include/variant/acpi/lte.asl
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#define LTE_EN GPP_A10 /* Active High */
+
+/* Method called from PEPD prior to enter s0ix state */
+Method (MS0X, 1)
+{
+	If (Arg0) {
+		/* Turn off lte power */
+		_SB.PCI0.STXS (LTE_EN)
+	} Else {
+		/* Turn on lte power */
+		_SB.PCI0.CTXS (LTE_EN)
+	}
+}