Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41404 )
Change subject: soc/intel/jasperlake: correct IRQ routing Jasper Lake ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41404/4/src/soc/intel/jasperlake/ac... File src/soc/intel/jasperlake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/41404/4/src/soc/intel/jasperlake/ac... PS4, Line 7: cAVS_INTA_IRQ can we term these an generic IRQs as in IRQ16, IRQ17, IRQ18, IRQ19?
and keep the LPSS IRQs only as device specific
https://review.coreboot.org/c/coreboot/+/41404/4/src/soc/intel/jasperlake/ac... PS4, Line 21: Package(){0x001CFFFF, 0, 0, PCIE_5_IRQ }, : Package(){0x001CFFFF, 1, 0, PCIE_6_IRQ }, : Package(){0x001CFFFF, 2, 0, PCIE_7_IRQ }, : Package(){0x001CFFFF, 3, 0, PCIE_8_IRQ }, not needed.
https://review.coreboot.org/c/coreboot/+/41404/4/src/soc/intel/jasperlake/ac... PS4, Line 38: Package(){0x0016FFFF, 0, 0, HECI_3_IRQ }, : Package(){0x0016FFFF, 1, 0, HECI_4_IRQ }, not needed, I think these would serve as duplicate entries.
https://review.coreboot.org/c/coreboot/+/41404/4/src/soc/intel/jasperlake/ac... PS4, Line 50: Package(){0x0014FFFF, 0, 0, CNViWIFI_IRQ }, duplicate..
-
Aamir Bohra (Code Review)