Change in coreboot[master]: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44930 )
Change subject: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX' ......................................................................
security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX'
ENABLE_VMX is already set to yes if CPU_INTEL_COMMON at 'cpu/intel/common/Kconfig' file.
Change-Id: Ib4582d86b08c68436d7f792194c9c5124885dd45 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/intel/txt/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/44930/1
diff --git a/src/security/intel/txt/Kconfig b/src/security/intel/txt/Kconfig index 3dd912e..d406858 100644 --- a/src/security/intel/txt/Kconfig +++ b/src/security/intel/txt/Kconfig @@ -4,7 +4,6 @@ bool "Intel TXT support" default n select MRC_SETTINGS_PROTECT if CACHE_MRC_SETTINGS - select ENABLE_VMX if CPU_INTEL_COMMON select AP_IN_SIPI_WAIT depends on (TPM1 || TPM2) depends on CPU_INTEL_FIRMWARE_INTERFACE_TABLE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44930 )
Change subject: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX' ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG@7 PS1, Line 7: redundant It is not redundant. TXT *requires* VMX to be enabled. The current approach will make sure ENABLE_VMX is selected when TXT support is enabled.
Sure, a `depends on` would also work, but it would instead hide TXT support unless ENABLE_VMX is selected, which is not user-friendly.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44930 )
Change subject: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG@7 PS1, Line 7: redundant
It is not redundant. TXT *requires* VMX to be enabled. […]
I agree. Another way to see it: ENABLE_VMX has a prompt and is user-configurable. And the `select` here makes sure the user can't break things.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44930 )
Change subject: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX' ......................................................................
Abandoned
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)