Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
mb/clevo/l140cu: Use lower-case hex values
Change-Id: I56a905980e5ae382c3488b9fddb9fab382efc1d6 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/48375/1
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb index acad20c..2e33c34 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb +++ b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb @@ -182,9 +182,9 @@ # Address 0x88: Decode 0x68 - 0x6F (PMC) register "gen2_dec" = "0x00040069" # Address 0x8C: Decode 0xE00 - 0xEFF (AP/EC command) - register "gen3_dec" = "0x00fc0E01" + register "gen3_dec" = "0x00fc0e01" # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) - register "gen4_dec" = "0x00fc0F01" + register "gen4_dec" = "0x00fc0f01" chip drivers/pc80/tpm # TPM device pnp 0c31.0 on end end
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48375/1/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48375/1/src/mainboard/clevo/cml-u/v... PS1, Line 184: # Address 0x8C: Decode 0xE00 - 0xEFF (AP/EC command) : register "gen3_dec" = "0x00fc0e01" : # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) : register "gen4_dec" = "0x00fc0f01" well, these were the values used for system76 ec; they need to be adapted anyways I guess (vendor uses different ones)
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48375/1/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48375/1/src/mainboard/clevo/cml-u/v... PS1, Line 184: # Address 0x8C: Decode 0xE00 - 0xEFF (AP/EC command) : register "gen3_dec" = "0x00fc0e01" : # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) : register "gen4_dec" = "0x00fc0f01"
well, these were the values used for system76 ec; they need to be adapted anyways I guess (vendor us […]
Vendor EC firmware isn't supported yet.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48375 )
Change subject: mb/clevo/l140cu: Use lower-case hex values ......................................................................
mb/clevo/l140cu: Use lower-case hex values
Change-Id: I56a905980e5ae382c3488b9fddb9fab382efc1d6 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/48375 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb index 5b03f4c..3bb802e 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb +++ b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb @@ -183,9 +183,9 @@ # Address 0x88: Decode 0x68 - 0x6F (PMC) register "gen2_dec" = "0x00040069" # Address 0x8C: Decode 0xE00 - 0xEFF (AP/EC command) - register "gen3_dec" = "0x00fc0E01" + register "gen3_dec" = "0x00fc0e01" # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) - register "gen4_dec" = "0x00fc0F01" + register "gen4_dec" = "0x00fc0f01" chip drivers/pc80/tpm # TPM device pnp 0c31.0 on end end
-
Felix Singer (Code Review) -
Frans Hendriks (Code Review)
-
Michael Niewöhner (Code Review)