Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74269 )
Change subject: mendocino: Print content of version file
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74269/comment/90e7e3a1_5a454fd6
PS1, Line 9: This commit adds printing content of 'fsp_version'
: file at ramstage.
Fits in one line (72 characters)?
https://review.coreboot.org/c/coreboot/+/74269/comment/de184235_6ca11cac
PS1, Line 11:
Please add the motivation. Something like (made up by me):
To process bug reports, it’s useful to have the blob versions in the coreboot log, so print out the versions from the file stored in CBFS. Note, if the blobs are updated, but the file is not, the versions differ.
File src/soc/amd/mendocino/fsp_version.c:
https://review.coreboot.org/c/coreboot/+/74269/comment/f9be330f_412b2f7d
PS1, Line 17: (int)size
Why the cast? `size_t` has the length modifier `z`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74269
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8df54b74cd987b4a3be635932d38ea178d0b0311
Gerrit-Change-Number: 74269
Gerrit-PatchSet: 1
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 07 Apr 2023 14:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment