Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Aamir Bohra, Fred Reitberger, Felix Held. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 )
Change subject: soc/amd/common/block/psp: Add platform secure boot support ......................................................................
Patch Set 17:
(2 comments)
File src/soc/amd/common/block/psp/psb.c:
https://review.coreboot.org/c/coreboot/+/60968/comment/db4b27e2_32c9c974 PS17, Line 18: /* PSB Test Status and Error Codes (doc#56654) */
PSB_TEST_STATUS_PASS is missing
As psb_test_status_to_string() is called in error scenarios so all error status codes are mentioned not the success one. Though PASS status can also be added (with PSB_TEST_STATUS_PASS is unused) for completeness, possibly for scenario where psb_test_status_to_string() is called without non-zero status check.
https://review.coreboot.org/c/coreboot/+/60968/comment/4b3e40de_cfc2b0f5 PS17, Line 30:
FUSE_STATUS_SUCCESS is missing
As fuse_status_to_string() is called in error scenarios, so all error status codes are mentioned and not the success one. Though SUCCESS status can also be added (with FUSE_STATUS_PASS unused) for completeness, possibly for scenario where fuse_status_to_string() is called without non-zero status check.
-
ritul guru (Code Review)