Change in ...coreboot[master]: sb/intel/common: Show Add EC firmware only for boards that need it
Jan Tatje has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30697
Change subject: sb/intel/common: Show Add EC firmware only for boards that need it ......................................................................
sb/intel/common: Show Add EC firmware only for boards that need it
Most boards currently do not use EC firmware from SPI flash in the IFD, this hides this option by default and shows it only for boards that need it.
A new config variable CAN_HAVE_EC_BIN is introduced to enable this option for boards that need it.
Change-Id: I52ab977319d99a23a5e982cc01479fe801e172a7 Signed-off-by: Jan Tatje jan@jnt.io --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/icelake_rvp/Kconfig M src/southbridge/intel/common/firmware/Kconfig 6 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/30697/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 711d2e9..8e185fa 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -15,6 +15,7 @@ select SOC_INTEL_CANNONLAKE_MEMCFG_INIT select SOC_INTEL_COFFEELAKE select SYSTEM_TYPE_LAPTOP + select CAN_HAVE_EC_BIN
if BOARD_GOOGLE_BASEBOARD_HATCH
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index c0bd1d8..f317886 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -22,6 +22,7 @@ select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP select TPM2 + select CAN_HAVE_EC_BIN
if BOARD_GOOGLE_BASEBOARD_SARIEN
diff --git a/src/mainboard/intel/cannonlake_rvp/Kconfig b/src/mainboard/intel/cannonlake_rvp/Kconfig index 028d493..683e53c 100644 --- a/src/mainboard/intel/cannonlake_rvp/Kconfig +++ b/src/mainboard/intel/cannonlake_rvp/Kconfig @@ -11,6 +11,7 @@ select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC select SOC_INTEL_CANNONLAKE + select CAN_HAVE_EC_BIN
config MAINBOARD_DIR string diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index 7597629..beb9cb9 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -16,6 +16,7 @@ select SOC_INTEL_CANNONLAKE_PCH_H if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP + select CAN_HAVE_EC_BIN
config MAINBOARD_DIR string diff --git a/src/mainboard/intel/icelake_rvp/Kconfig b/src/mainboard/intel/icelake_rvp/Kconfig index 0741bf8..788dae5 100644 --- a/src/mainboard/intel/icelake_rvp/Kconfig +++ b/src/mainboard/intel/icelake_rvp/Kconfig @@ -13,6 +13,7 @@ select DRIVERS_USB_ACPI select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_ICELAKE + select CAN_HAVE_EC_BIN
config MAINBOARD_DIR string diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index 97fb993..0fbb9b9 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -120,8 +120,11 @@ depends on HAVE_GBE_BIN default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/gbe.bin"
+config CAN_HAVE_EC_BIN + def_bool n + config HAVE_EC_BIN - bool "Add EC firmware" + bool "Add EC firmware" if CAN_HAVE_EC_BIN depends on HAVE_IFD_BIN help The embedded controller needs a firmware file.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30697 )
Change subject: sb/intel/common: Show "Add EC firmware" only for boards that need it ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30697/3/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/30697/3/src/mainboard/google/hatch/Kconfig@1... PS3, Line 18: MAINBOARD_USES_IFD_EC_REGION i don't know how you have concluded that hatch will use EC region in IFD?
Can you please check below .fmd file for hatch, do you see EC region. i don't think we are packing anything in EC region for hatch. its a separate binary that we flash differently. its not same as Intel RVP model.
https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/hatch/...
-
Jan Tatje (Code Review) -
Subrata Banik (Code Review)