Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 )
Change subject: mb/google/guybrush/var/nipperkin: Update SPKR, SD_AUX_RESET_L GPIO configuration
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59051/comment/5b8f0381_5d813922
PS2, Line 12: SD_AUX_RESET_L: GPIO69
I am not sure if we missed the GPIO change in the hardware build. Based on my offline discussion with Rob, it seems safe to move to GPIO69 for all the boards.
Rob, WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e
Gerrit-Change-Number: 59051
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Tue, 09 Nov 2021 17:37:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment