Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 )
Change subject: mediatek/mt8183: Set DRAM voltage for each DRAM frequency
......................................................................
Patch Set 11: Code-Review-1
@huayang, please remove the +2 and address the feedbacks in comments.
also I really think we can avoid the use of '#if Xplease try to avoid @huayaXX'.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e
Gerrit-Change-Number: 35017
Gerrit-PatchSet: 11
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 08:27:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment