Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
mb/google/zork: Always load and run display oprom
The kernel requires the display oprom is loaded and ran in order for the kernel to not panic. Therefore, select the correct settings such that normal mode works for Chrome OS.
BUG=b:160560510 TEST=Boot Trembyle in developer mode and normal mode
Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43257/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index e24f78a..fec844d 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -13,6 +13,8 @@ select SOC_AMD_COMMON_BLOCK_USE_ESPI select SOC_AMD_PICASSO select VGA_BIOS + select ALWAYS_LOAD_OPROM + select ALWAYS_RUN_OPROM select BOARD_ROMSIZE_KB_16384 select DISABLE_SPI_FLASH_ROM_SHARING select DRIVERS_GENERIC_GPIO_KEYS
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
Patch Set 1:
Same fix from Kahlee: https://review.coreboot.org/c/coreboot/+/23506
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... PS1, Line 17: select ALWAYS_RUN_OPROM I think this is true for all amd systems with display. We probably want to move this to soc?
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... PS1, Line 17: select ALWAYS_RUN_OPROM
I think this is true for all amd systems with display. […]
Can we get someone from AMD to confirm. I don't see this flag being set in mainboard/amd/*
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: mb/google/zork: Always load and run display oprom ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... PS1, Line 17: select ALWAYS_RUN_OPROM
Can we get someone from AMD to confirm. […]
Aaron is saying soc/amd/picasso/Kconfig
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Martin Roth, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43257
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
soc/amd/picasso: Always load and run display oprom
The kernel requires the display oprom is loaded and ran in order for the kernel to not panic. Therefore, select the correct settings such that normal mode works for Chrome OS.
BUG=b:160560510 TEST=Boot Trembyle in developer mode and normal mode
Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf Signed-off-by: Rob Barnes robbarnes@google.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43257/2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/1/src/mainboard/google/zork/K... PS1, Line 17: select ALWAYS_RUN_OPROM
Aaron is saying soc/amd/picasso/Kconfig
Done
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2:
just had a look and in my Mandolin builds I only select VGA_ROM_RUN
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
just had a look and in my Mandolin builds I only select VGA_ROM_RUN
Because it's using depth
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig... PS2, Line 344: select CHROMEOS_RAMOOPS_DYNAMIC Move the selects to here?
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
Patch Set 2:
just had a look and in my Mandolin builds I only select VGA_ROM_RUN
Because it's using depth
Ignore that. I had started a thought about depthcharge, then went looking in kconfig.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
just had a look and in my Mandolin builds I only select VGA_ROM_RUN
Because it's using depth
Ignore that. I had started a thought about depthcharge, then went looking in kconfig.
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig... PS2, Line 344: select CHROMEOS_RAMOOPS_DYNAMIC
Move the selects to here?
Yes, my preference too. Or worst case, move to zork/Kconfig. Could be a stupid question; I haven't looked, but what about VGA_ROM_RUN instead.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig... PS2, Line 344: select CHROMEOS_RAMOOPS_DYNAMIC
Yes, my preference too. Or worst case, move to zork/Kconfig. […]
re zork/config: See patch 1 comments.
re VGA_ROM_RUN: That could work. ALWAYS_LOAD_OPROM and ALWAYS_RUN_OPROM depend on VGA_ROM_RUN, so that would ensure the dependency has been met.
Hello build bot (Jenkins), Raul Rangel, Martin Roth, Furquan Shaikh, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43257
to look at the new patch set (#3).
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
soc/amd/picasso: Always load and run display oprom
The kernel requires the display oprom is loaded and ran in order for the kernel to not panic. Therefore, select the correct settings such that normal mode works for Chrome OS.
BUG=b:160560510 TEST=Boot Trembyle in developer mode and normal mode
Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf Signed-off-by: Rob Barnes robbarnes@google.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43257/3
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 3: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 3:
comments need to be resolved in order to submit
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig... PS2, Line 344: select CHROMEOS_RAMOOPS_DYNAMIC
re zork/config: See patch 1 comments. […]
Done
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom ......................................................................
soc/amd/picasso: Always load and run display oprom
The kernel requires the display oprom is loaded and ran in order for the kernel to not panic. Therefore, select the correct settings such that normal mode works for Chrome OS.
BUG=b:160560510 TEST=Boot Trembyle in developer mode and normal mode
Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43257 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/soc/amd/picasso/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 4d07af6..87d8c51 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -340,6 +340,8 @@
config CHROMEOS select CHROMEOS_RAMOOPS_DYNAMIC + select ALWAYS_LOAD_OPROM + select ALWAYS_RUN_OPROM
config RO_REGION_ONLY string