Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43257 )
Change subject: soc/amd/picasso: Always load and run display oprom
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
just had a look and in my Mandolin builds I only select VGA_ROM_RUN
Because it's using depth
Ignore that. I had started a thought about depthcharge, then went looking in kconfig.
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/43257/2/src/soc/amd/picasso/Kconfig...
PS2, Line 344: select CHROMEOS_RAMOOPS_DYNAMIC
Move the selects to here?
Yes, my preference too. Or worst case, move to zork/Kconfig. Could be a stupid question; I haven't looked, but what about VGA_ROM_RUN instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf
Gerrit-Change-Number: 43257
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Thu, 09 Jul 2020 01:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment