Aaron Durbin submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
soc/amd/picasso: Always load and run display oprom

The kernel requires the display oprom is loaded and ran
in order for the kernel to not panic. Therefore, select the
correct settings such that normal mode works for Chrome OS.

BUG=b:160560510
TEST=Boot Trembyle in developer mode and normal mode

Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43257
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
---
M src/soc/amd/picasso/Kconfig
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 4d07af6..87d8c51 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -340,6 +340,8 @@

config CHROMEOS
select CHROMEOS_RAMOOPS_DYNAMIC
+ select ALWAYS_LOAD_OPROM
+ select ALWAYS_RUN_OPROM

config RO_REGION_ONLY
string

To view, visit change 43257. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6bcc99f8880a45818f959a957660c2c43b1bfdf
Gerrit-Change-Number: 43257
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Marshall Dawson <marshall.dawson@amd.corp-partner.google.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-MessageType: merged