[S] Change in coreboot[main]: i2c/drivers/generic: Add support for including a rotation matrix - coreboot-gerrit

20 Feb 2024


      Attention is currently required from: Matt DeVillier, Paul Menzel, Sean Rhodes.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80179?usp=email )
Change subject: i2c/drivers/generic: Add support for including a rotation matrix
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/80179/comment/2aeb943f_21d623c3 :
PS4, Line 81: int
...
I copied `detect` - should that be a bool?
yeah, probed and detected should probably also be bool, but that's something for a separate patch. we'll probably also need a types.h include to have the bool type
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
Gerrit-Change-Number: 80179
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 20 Feb 2024 12:52:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes sean@starlabs.systems
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment