Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85828?usp=email )
Change subject: mb/google/rauru: Determine PCIe init by storage_id ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85828/comment/26f9fa30_6213928f?usp... : PS2, Line 52: return storage_id() == 3;
I am thinking if we could follow pcie/regulator that has a `soc/storage. […]
That's even better. I assume you meant
``` // soc/storage.h (shared for all SoCs) #define ... enum mtk_storage_type { };
// mb/google/BOARD/boardid.c enum mtk_storage_type mainboard_get_storage_type(void) { } ```
Then, `soc_init` will call `mainboard_get_storage_type()` and pass it to mtk-fsp. Is my understanding correct?