Attention is currently required from: Karthik Ramasubramanian, Naveen M, Paul Menzel, Pranava Y N, Varun Upadhyay.
Subrata Banik has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85282?usp=email )
Change subject: drivers/soundwire/alc711: Add common Kconfig for ALC7xx soundwire codecs
......................................................................
Patch Set 8: -Code-Review
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85282/comment/8b2b6eb1_f8c8bd88?usp... :
PS7, Line 110: config->alc711_address[dev->path.generic.id].version = SOUNDWIRE_VERSION_1_1;
: config->alc711_address[dev->path.generic.id].class = MIPI_CLASS_NONE;
: } else {
: config->alc711_address[dev->path.generic.id].version = SOUNDWIRE_VERSION_1_2;
: config->alc711_address[dev->path.generic.id].class = MIPI_CLASS_SDCA;
hi Karthik,
The version & class are only changing for ALC711 to maintain backward compatibility while for ALC721 and ALC722 its same so it doesnt make sense to update from devicetree currently.
I guess it only make sense if there is a need to uprev the version beyond 1.2 then there will be unnecessary if/else
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5953d0fcb7b15368888901f88c5616757ac42877
Gerrit-Change-Number: 85282
Gerrit-PatchSet: 8
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Naveen M
naveen.m@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Tue, 03 Dec 2024 15:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Varun Upadhyay
varun.upadhyay@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com