Xiang Wang has posted comments on this change. ( https://review.coreboot.org/28394 )
Change subject: riscv: Add DEFINE_MPRV_READ_MXR to read execution-only page
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28394/1/src/arch/riscv/include/vm.h
File src/arch/riscv/include/vm.h:
https://review.coreboot.org/#/c/28394/1/src/arch/riscv/include/vm.h@41
PS1, Line 41: #define DEFINE_MPRV_READ_FLAGS(name, type, insn, flags) \
I suggest the following: […]
Done
--
To view, visit
https://review.coreboot.org/28394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19519782fe791982a8fbd48ef33b5a92a3c48bfc
Gerrit-Change-Number: 28394
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn Chang
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Aug 2018 13:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No