Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42362 )
Change subject: ACPI: Replace smm_setup_structures()
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42362/4/src/acpi/gnvs.c
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/42362/4/src/acpi/gnvs.c@32
PS4, Line 32: if (!gnvs)
It seems like you are assuming a caller is calling acpi_get_gnvs() prior to set_smm_gnvs_ptr(). […]
Moved the function. This file is acpi/ so inline asm denied here.
https://review.coreboot.org/c/coreboot/+/42362/4/src/arch/x86/acpi_s3.c
File src/arch/x86/acpi_s3.c:
https://review.coreboot.org/c/coreboot/+/42362/4/src/arch/x86/acpi_s3.c@84
PS4, Line 84: Why?
Ah.. it changed with PARALLEL_MP then. From i82801ix/smi.c: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31ec85ebce03d0d472403806969f863e4ca03b6b
Gerrit-Change-Number: 42362
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 10:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment