Change in ...coreboot[master]: sdm845: Add QUPv3 FW load & config

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 )

Change subject: sdm845: Add QUPv3 FW load & config
......................................................................

Patch Set 63:

(1 comment)

https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con... 
File src/mainboard/google/cheza/qupv3_config.c:

https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con... 
PS6, Line 18: struct se_cfg se_mappings[QUPV3_SE_MAX] =
This is the first SoC we ever had that has to load firmware to get basic peripherals working, so there's no existing reference I could point you to. Just make a qupv3_load_firmware(qup_nr, type) function and call it from the top of qup_spi_init() or something like that.
> Should we call respective instance driver init function from ramstage? So that will load FW and configure the required QUP.

Yeah, I think those should be called from mainboard.c in ramstage.