Felix Held has posted comments on this change. ( https://review.coreboot.org/28368 )
Change subject: Documentation: add description for util/pmh7tool
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28368/2/util/pmh7tool/description.md
File util/pmh7tool/description.md:
https://review.coreboot.org/#/c/28368/2/util/pmh7tool/description.md@1
PS2, Line 1: Dumps PMH7 registers on Lenovo ThinkPads. `C`
The tool can not only dump the register space, but also write registers. I'd suggest to add that to the description. Maybe also add that the pmh7 is for example used for switching on and off the power of some devices on the board.
--
To view, visit
https://review.coreboot.org/28368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5daf101a9ff27aa49b7849bf6bf39362b8db09
Gerrit-Change-Number: 28368
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Tom Hiller
thrilleratplay@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 16 Sep 2018 19:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No