Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
mb/google/parrot: Get rid of hard-coded function names in printks
Instead of hard-coding function names in strings, use the __func__ constant to fix linter issues.
Change-Id: I151560cd5a135e00f494eda3f9d3b592ee9d984a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/parrot/smihandler.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/49199/1
diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c index 22e372d..baa9197 100644 --- a/src/mainboard/google/parrot/smihandler.c +++ b/src/mainboard/google/parrot/smihandler.c @@ -18,7 +18,7 @@
ec_kbc_write_cmd(0x56); src = ec_kbc_read_ob(); - printk(BIOS_DEBUG, "mainboard_smi_ec src: %x\n", src); + printk(BIOS_DEBUG, "%s: %x\n", __func__, src);
switch (src) { case EC_BATTERY_CRITICAL: @@ -51,7 +51,7 @@
void mainboard_smi_sleep(u8 slp_typ) { - printk(BIOS_DEBUG, "mainboard_smi_sleep: %x\n", slp_typ); + printk(BIOS_DEBUG, "%s: %x\n", __func__, slp_typ); /* Disable SCI and SMI events */
/* Clear pending events that may trigger immediate wake */ @@ -67,7 +67,7 @@
int mainboard_smi_apmc(u8 apmc) { - printk(BIOS_DEBUG, "mainboard_smi_apmc: %x\n", apmc); + printk(BIOS_DEBUG, "%s: %x\n", __func__, apmc); switch (apmc) { case APM_CNT_ACPI_ENABLE: printk(BIOS_DEBUG, "APMC: ACPI_EN\n");
Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/cf1ed6e6_51c095e2 PS1, Line 21: printk(BIOS_DEBUG, "%s: %x\n", __func__, src); You've deleted the `src` part
https://review.coreboot.org/c/coreboot/+/49199/comment/f53aa8f9_34916fee PS1, Line 39: mainboard_smi_gpi another case
Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49199/comment/c7df6fb7_bd77e2f6 PS1, Line 9: use the __func__ : constant to fix linter issues Please don't do it for the linter. Do it for better maintainability :-P
Attention is currently required from: Felix Singer. Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49199
to look at the new patch set (#2).
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
mb/google/parrot: Get rid of hard-coded function names in printks
Instead of hard-coding function names in strings, use the __func__ constant for better maintainability.
Change-Id: I151560cd5a135e00f494eda3f9d3b592ee9d984a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/parrot/smihandler.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/49199/2
Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49199/comment/4f5dcce8_ab934c59 PS1, Line 9: use the __func__ : constant to fix linter issues
Please don't do it for the linter. […]
Yes, you are right. Adjusted the commit message so that it doesn't sound wrong.
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/423c6329_72a6ce84 PS1, Line 21: printk(BIOS_DEBUG, "%s: %x\n", __func__, src);
You've deleted the `src` part
Done
https://review.coreboot.org/c/coreboot/+/49199/comment/966c2ee5_5d4d54bb PS1, Line 39: mainboard_smi_gpi
another case
Done
Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/27d37049_2313c713 PS1, Line 39: mainboard_smi_gpi
Done
git grep mainboard_smi | grep printk
src/mainboard/google/butterfly/mainboard_smi.c src/mainboard/lenovo/s230u/smihandler.c
Up to you whether to do those in separate commit.
Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2: Code-Review+2
Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2: Code-Review+2
Attention is currently required from: Kyösti Mälkki. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/acf64229_2a53c298 PS1, Line 39: mainboard_smi_gpi
git grep mainboard_smi | grep printk […]
Thanks for that, will do these in a seperate patch.
Attention is currently required from: Felix Singer. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/7c3c427a_15a12178 PS1, Line 39: mainboard_smi_gpi
Thanks for that, will do these in a seperate patch.
I have some related works. TBH I think these printk's are redundant with logging in sb/smihandler.c.
Attention is currently required from: Felix Singer. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49199/comment/88a3744b_89e24ff0 PS1, Line 39: mainboard_smi_gpi
I have some related works. TBH I think these printk's are redundant with logging in sb/smihandler.c.
CB:49249 but I don't mind this getting merged or your works instead.
Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49199
to look at the new patch set (#5).
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
mb/google/parrot: Get rid of hard-coded function names in printks
Instead of hard-coding function names in strings, use the __func__ constant for better maintainability.
Change-Id: I151560cd5a135e00f494eda3f9d3b592ee9d984a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/parrot/smihandler.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/49199/5
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49199 )
Change subject: mb/google/parrot: Get rid of hard-coded function names in printks ......................................................................
mb/google/parrot: Get rid of hard-coded function names in printks
Instead of hard-coding function names in strings, use the __func__ constant for better maintainability.
Change-Id: I151560cd5a135e00f494eda3f9d3b592ee9d984a Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/49199 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/parrot/smihandler.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c index 22e372d..a0b067c 100644 --- a/src/mainboard/google/parrot/smihandler.c +++ b/src/mainboard/google/parrot/smihandler.c @@ -18,7 +18,7 @@
ec_kbc_write_cmd(0x56); src = ec_kbc_read_ob(); - printk(BIOS_DEBUG, "mainboard_smi_ec src: %x\n", src); + printk(BIOS_DEBUG, "%s src: %x\n", __func__, src);
switch (src) { case EC_BATTERY_CRITICAL: @@ -36,7 +36,7 @@
void mainboard_smi_gpi(u32 gpi_sts) { - printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts); + printk(BIOS_DEBUG, "%s: %x\n", __func__, gpi_sts); if (gpi_sts & (1 << EC_SMI_GPI)) { /* Process all pending events from EC */ while (mainboard_smi_ec() != EC_NO_EVENT); @@ -51,7 +51,7 @@
void mainboard_smi_sleep(u8 slp_typ) { - printk(BIOS_DEBUG, "mainboard_smi_sleep: %x\n", slp_typ); + printk(BIOS_DEBUG, "%s: %x\n", __func__, slp_typ); /* Disable SCI and SMI events */
/* Clear pending events that may trigger immediate wake */ @@ -67,7 +67,7 @@
int mainboard_smi_apmc(u8 apmc) { - printk(BIOS_DEBUG, "mainboard_smi_apmc: %x\n", apmc); + printk(BIOS_DEBUG, "%s: %x\n", __func__, apmc); switch (apmc) { case APM_CNT_ACPI_ENABLE: printk(BIOS_DEBUG, "APMC: ACPI_EN\n");