Nico Huber submitted this change.
mb/google/parrot: Get rid of hard-coded function names in printks
Instead of hard-coding function names in strings, use the __func__
constant for better maintainability.
Change-Id: I151560cd5a135e00f494eda3f9d3b592ee9d984a
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49199
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M src/mainboard/google/parrot/smihandler.c
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c
index 22e372d..a0b067c 100644
--- a/src/mainboard/google/parrot/smihandler.c
+++ b/src/mainboard/google/parrot/smihandler.c
@@ -18,7 +18,7 @@
ec_kbc_write_cmd(0x56);
src = ec_kbc_read_ob();
- printk(BIOS_DEBUG, "mainboard_smi_ec src: %x\n", src);
+ printk(BIOS_DEBUG, "%s src: %x\n", __func__, src);
switch (src) {
case EC_BATTERY_CRITICAL:
@@ -36,7 +36,7 @@
void mainboard_smi_gpi(u32 gpi_sts)
{
- printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts);
+ printk(BIOS_DEBUG, "%s: %x\n", __func__, gpi_sts);
if (gpi_sts & (1 << EC_SMI_GPI)) {
/* Process all pending events from EC */
while (mainboard_smi_ec() != EC_NO_EVENT);
@@ -51,7 +51,7 @@
void mainboard_smi_sleep(u8 slp_typ)
{
- printk(BIOS_DEBUG, "mainboard_smi_sleep: %x\n", slp_typ);
+ printk(BIOS_DEBUG, "%s: %x\n", __func__, slp_typ);
/* Disable SCI and SMI events */
/* Clear pending events that may trigger immediate wake */
@@ -67,7 +67,7 @@
int mainboard_smi_apmc(u8 apmc)
{
- printk(BIOS_DEBUG, "mainboard_smi_apmc: %x\n", apmc);
+ printk(BIOS_DEBUG, "%s: %x\n", __func__, apmc);
switch (apmc) {
case APM_CNT_ACPI_ENABLE:
printk(BIOS_DEBUG, "APMC: ACPI_EN\n");
To view, visit change 49199. To unsubscribe, or for help writing mail filters, visit settings.