Change in coreboot[master]: mb/google/parrot: Let else statement follow closing brace

[Felix Singer (Code Review)]

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49200 )

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

mb/google/parrot: Let else statement follow closing brace

Fixes a linter error.

Change-Id: I1302e32b0d52e37d9cb4503128edc7d1df1c3bd8
Signed-off-by: Felix Singer 
---
M src/mainboard/google/parrot/smihandler.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/49200/1

diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c
index baa9197..9d96473 100644
--- a/src/mainboard/google/parrot/smihandler.c
+++ b/src/mainboard/google/parrot/smihandler.c
@@ -40,8 +40,7 @@
    if (gpi_sts & (1 << EC_SMI_GPI)) {
    	/* Process all pending events from EC */
    	while (mainboard_smi_ec() != EC_NO_EVENT);
-	}
-	else if (gpi_sts & (1 << EC_LID_GPI)) {
+	} else if (gpi_sts & (1 << EC_LID_GPI)) {
    	printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");

/* Go to S5 */

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49200 )

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

File src/mainboard/google/parrot/smihandler.c:

https://review.coreboot.org/c/coreboot/+/49200/comment/6a8db75e_d00d55d0 
PS1, Line 42: 		while (mainboard_smi_ec() != EC_NO_EVENT);
Personally, I'd add a newline here to separate both branches

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49200 )

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/parrot/smihandler.c:

https://review.coreboot.org/c/coreboot/+/49200/comment/05584daf_9b2eedeb 
PS1, Line 42: 		while (mainboard_smi_ec() != EC_NO_EVENT);
> Personally, I'd add a newline here to separate both branches

Should be handled in a different patch.

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49200 )

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/parrot/smihandler.c:

https://review.coreboot.org/c/coreboot/+/49200/comment/8e9ae735_6abfd0e5 
PS1, Line 42: 		while (mainboard_smi_ec() != EC_NO_EVENT);
> Should be handled in a different patch.

Ah, just noticed that I've done it in CB:49201 😄

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49200 )

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/parrot/smihandler.c:

https://review.coreboot.org/c/coreboot/+/49200/comment/545d3ac7_cb6b812b 
PS1, Line 42: 		while (mainboard_smi_ec() != EC_NO_EVENT);
> Ah, just noticed that I've done it in CB:49201 😄

No, I meant an empty line to separate the if-block from the else-block. It's not related to the semicolon.

[Felix Singer (Code Review)]

Attention is currently required from:  Felix Singer.
Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49200

to look at the new patch set (#5).

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

mb/google/parrot: Let else statement follow closing brace

Fixes a linter error.

Change-Id: I1302e32b0d52e37d9cb4503128edc7d1df1c3bd8
Signed-off-by: Felix Singer 
---
M src/mainboard/google/parrot/smihandler.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/49200/5

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49200 )

Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................

mb/google/parrot: Let else statement follow closing brace

Fixes a linter error.

Change-Id: I1302e32b0d52e37d9cb4503128edc7d1df1c3bd8
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49200
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/google/parrot/smihandler.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c
index a0b067c..0a4f249 100644
--- a/src/mainboard/google/parrot/smihandler.c
+++ b/src/mainboard/google/parrot/smihandler.c
@@ -40,8 +40,7 @@
    if (gpi_sts & (1 << EC_SMI_GPI)) {
    	/* Process all pending events from EC */
    	while (mainboard_smi_ec() != EC_NO_EVENT);
-	}
-	else if (gpi_sts & (1 << EC_LID_GPI)) {
+	} else if (gpi_sts & (1 << EC_LID_GPI)) {
    	printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");

/* Go to S5 */