Change in coreboot[master]: 3rdparts/fsp: Update dependency and fix cannonlake Fsp.fd path
Mimoja has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update dependency and fix cannonlake Fsp.fd path ......................................................................
3rdparts/fsp: Update dependency and fix cannonlake Fsp.fd path
The name for the CoffeeLake FSP.fd was changed to Fsp.fd. Therefore the CoffeLake / WhiskeyLake default path was changed.
Change-Id: I0f51e378fcaacb25392d8940a342fc968c730157 Signed-off-by: Johanna Schander coreboot@mimoja.de --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37564/1
diff --git a/3rdparty/fsp b/3rdparty/fsp index 5996417..0bc2b07 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 59964173e18950debcc6b8856c5c928935ce0b4f +Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 5c91ac1..c82660e 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -310,7 +310,7 @@ config FSP_FD_PATH string depends on FSP_USE_REPO - default "3rdparty/fsp/CoffeeLakeFspBinPkg/FSP.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "3rdparty/fsp/CoffeeLakeFspBinPkg/Fsp.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
config SOC_INTEL_CANNONLAKE_DEBUG_CONSENT int "Debug Consent for CNL"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update dependency and fix cannonlake Fsp.fd path ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37564/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37564/1//COMMIT_MSG@7 PS1, Line 7: dependency submodule
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37564
to look at the new patch set (#2).
Change subject: 3rdparts/fsp: Update fsp submodule and fix CannonLake Fsp.fd path ......................................................................
3rdparts/fsp: Update fsp submodule and fix CannonLake Fsp.fd path
The name for the CoffeeLake FSP.fd was changed to Fsp.fd. Therefore the CoffeLake / WhiskeyLake default path was changed.
Change-Id: I0f51e378fcaacb25392d8940a342fc968c730157 Signed-off-by: Johanna Schander coreboot@mimoja.de --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37564/2
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule and fix CannonLake Fsp.fd path ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37564/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37564/1//COMMIT_MSG@7 PS1, Line 7: dependency
submodule
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule and fix CannonLake Fsp.fd path ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37564/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37564/3//COMMIT_MSG@7 PS3, Line 7: and fix CannonLake Fsp.fd path No need to mention this in the summary line, imho (also, it's actually not fixing something, just keeping it aligned).
Hello Patrick Rudolph, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37564
to look at the new patch set (#4).
Change subject: 3rdparts/fsp: Update fsp submodule ......................................................................
3rdparts/fsp: Update fsp submodule
The name for the CoffeeLake FSP.fd was changed to Fsp.fd. Therefore the CoffeLake / WhiskeyLake default path was changed.
Change-Id: I0f51e378fcaacb25392d8940a342fc968c730157 Signed-off-by: Johanna Schander coreboot@mimoja.de --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37564/4
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37564/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37564/3//COMMIT_MSG@7 PS3, Line 7: and fix CannonLake Fsp.fd path
No need to mention this in the summary line, imho (also, it's […]
Done
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule ......................................................................
Patch Set 4: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule ......................................................................
3rdparts/fsp: Update fsp submodule
The name for the CoffeeLake FSP.fd was changed to Fsp.fd. Therefore the CoffeLake / WhiskeyLake default path was changed.
Change-Id: I0f51e378fcaacb25392d8940a342fc968c730157 Signed-off-by: Johanna Schander coreboot@mimoja.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/37564 Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, but someone else must approve
diff --git a/3rdparty/fsp b/3rdparty/fsp index 5996417..0bc2b07 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 59964173e18950debcc6b8856c5c928935ce0b4f +Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 5c91ac1..c82660e 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -310,7 +310,7 @@ config FSP_FD_PATH string depends on FSP_USE_REPO - default "3rdparty/fsp/CoffeeLakeFspBinPkg/FSP.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "3rdparty/fsp/CoffeeLakeFspBinPkg/Fsp.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
config SOC_INTEL_CANNONLAKE_DEBUG_CONSENT int "Debug Consent for CNL"
Christian Walter has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule ......................................................................
Christian Walter has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/37564 )
Change subject: 3rdparts/fsp: Update fsp submodule ......................................................................
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Felix Singer (Code Review)
-
Mimoja (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)