Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email )
Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79930/comment/4fd541da_6740b9f4 :
PS7, Line 7: mb/google/dedede
Should the prefix also contain `/var/pirka`?
Done
https://review.coreboot.org/c/coreboot/+/79930/comment/8867c0a4_6da36c67 :
PS7, Line 16: For Palutena project, the SKU ID segment of Palutena is set for
: "0x350000~0x35FFFF".
But why these values?
Because of NEW PROJECT.
And this SKU ID is provided by Google SIE Shou-Chieh Hsu.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79930?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2
Gerrit-Change-Number: 79930
Gerrit-PatchSet: 8
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Anson Tseng
ansontseng@google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anson Tseng
ansontseng@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 11:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment