Attention is currently required from: Hung-Te Lin, Rui Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/348e1f1b_32f838d4?usp... : PS1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { It looks like the configuration for MAX98390 and TAS2563 are the same in coreboot. If we only differentiate the AMPs in payload, you can just write ``` if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390)) || fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { ... ) ```
File src/mainboard/google/geralt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83287/comment/fb4390e5_548a5e19?usp... : PS1, Line 4: AUDIO_AMP do we reserve the bits for NAU8318 ?