Attention is currently required from: Hung-Te Lin, Rui Zhou, Yu-Ping Wu.
2 comments:
File src/mainboard/google/geralt/chromeos.c:
Patch Set #1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) {
It looks like the configuration for MAX98390 and TAS2563 are the same in coreboot.
If we only differentiate the AMPs in payload, you can just write
```
if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390)) ||
fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
...
)
```
File src/mainboard/google/geralt/devicetree.cb:
Patch Set #1, Line 4: AUDIO_AMP
do we reserve the bits for NAU8318 ?
To view, visit change 83287. To unsubscribe, or for help writing mail filters, visit settings.