Change in coreboot[master]: mb/google/dedede/var/drawcia: Support VBT for Drawman

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48192 )

Change subject: mb/google/dedede/var/drawcia: Support VBT for Drawman
......................................................................

mb/google/dedede/var/drawcia: Support VBT for Drawman

Default VBT supports only integrated Display port. Drawman supports a
HDMI port and hence support a separate VBT for Drawman.

BUG=b:161190931
BRANCH=dedede
TEST=Build and boot to OS in Drawlat and Drawman.

Change-Id: I8895cc67d87428eddb31328f1e3a90c346b54533
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/mainboard/google/dedede/variants/drawcia/variant.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/48192/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c
index 88e9de7..b5effbb 100644
--- a/src/mainboard/google/dedede/variants/drawcia/variant.c
+++ b/src/mainboard/google/dedede/variants/drawcia/variant.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <bootstate.h>
+#include <drivers/intel/gma/opregion.h>
 #include <fw_config.h>
 #include <sar.h>

@@ -13,3 +14,11 @@

return filename;
 }
+
+const char *mainboard_vbt_filename(void)
+{
+	if (fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_1A_HDMI)))
+		return "vbt_drawman.bin";
+
+	return "vbt.bin";
+}

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48192 )

Change subject: mb/google/dedede/var/drawcia: Support VBT for Drawman
......................................................................

Patch Set 1: Code-Review+2

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48192 )

Change subject: mb/google/dedede/var/drawcia: Support VBT for Drawman
......................................................................

Patch Set 1: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Maulik V Vaghela, Marco Chen,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48192

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/drawcia: Support VBT for Drawman
......................................................................

mb/google/dedede/var/drawcia: Support VBT for Drawman

Default VBT supports only integrated Display port. Drawman supports a
HDMI port and hence support a separate VBT for Drawman.

BUG=b:161190931
BRANCH=dedede
TEST=Build and boot to OS in Drawlat and Drawman.

Cq-Depend: TBD
Change-Id: I8895cc67d87428eddb31328f1e3a90c346b54533
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/mainboard/google/dedede/variants/drawcia/variant.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/48192/2

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48192 )

Change subject: mb/google/dedede/var/drawcia: Support VBT for Drawman
......................................................................

Patch Set 3:

Verified it on Drawman with HDMI:

fw_config match found: DB_PORTS=DB_PORTS_1A_HDMI
FMAP: area FW_MAIN_A found @ 483000 (2172864 bytes)
CBFS: Found 'vbt_drawman.bin' @0xbb500 size 0x4b6

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48192 )

Change subject: mb/google/dedede/var/drawcia: Support VBT for Drawman
......................................................................

mb/google/dedede/var/drawcia: Support VBT for Drawman

Default VBT supports only integrated Display port. Drawman supports a
HDMI port and hence support a separate VBT for Drawman.

BUG=b:161190931
BRANCH=dedede
TEST=Build and boot to OS in Drawlat and Drawman.

Cq-Depend: TBD
Change-Id: I8895cc67d87428eddb31328f1e3a90c346b54533
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48192
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Maulik V Vaghela 
---
M src/mainboard/google/dedede/variants/drawcia/variant.c
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Maulik V Vaghela: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c
index 88e9de7..b5effbb 100644
--- a/src/mainboard/google/dedede/variants/drawcia/variant.c
+++ b/src/mainboard/google/dedede/variants/drawcia/variant.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <bootstate.h>
+#include <drivers/intel/gma/opregion.h>
 #include <fw_config.h>
 #include <sar.h>

@@ -13,3 +14,11 @@

return filename;
 }
+
+const char *mainboard_vbt_filename(void)
+{
+	if (fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_1A_HDMI)))
+		return "vbt_drawman.bin";
+
+	return "vbt.bin";
+}