Change in coreboot[master]: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_d...
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37688 )
Change subject: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_def.h> ......................................................................
mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_def.h>
Change-Id: I4dcdcb734e20830ac97d4a826de61017afc6ee67 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/bettong/BiosCallOuts.c M src/mainboard/amd/db-ft3b-lc/romstage.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/lamar/romstage.c M src/mainboard/amd/olivehillplus/romstage.c M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/getac/p470/mainboard.c M src/mainboard/gizmosphere/gizmo/mainboard.c M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/link/early_init.c M src/mainboard/google/link/mainboard.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/google/stout/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c M src/mainboard/intel/d510mo/mainboard.c M src/mainboard/intel/emeraldlake2/mainboard.c M src/mainboard/intel/wtm2/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/early_init.c M src/mainboard/lenovo/t430s/variants/t431s/romstage.c M src/mainboard/lenovo/t60/mainboard.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/mainboard.c M src/mainboard/supermicro/x10slm-f/mainboard.c 35 files changed, 0 insertions(+), 35 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37688/1
diff --git a/src/mainboard/amd/bettong/BiosCallOuts.c b/src/mainboard/amd/bettong/BiosCallOuts.c index a6f424e..e901365 100644 --- a/src/mainboard/amd/bettong/BiosCallOuts.c +++ b/src/mainboard/amd/bettong/BiosCallOuts.c @@ -14,7 +14,6 @@ */
#include <console/console.h> -#include <device/pci_def.h> #include <device/device.h> #include <AGESA.h> #include <northbridge/amd/agesa/BiosCallOuts.h> diff --git a/src/mainboard/amd/db-ft3b-lc/romstage.c b/src/mainboard/amd/db-ft3b-lc/romstage.c index a3ad3a1..265fa01 100644 --- a/src/mainboard/amd/db-ft3b-lc/romstage.c +++ b/src/mainboard/amd/db-ft3b-lc/romstage.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/amd/lamar/mainboard.c b/src/mainboard/amd/lamar/mainboard.c index 3d33850..2b4dabd 100644 --- a/src/mainboard/amd/lamar/mainboard.c +++ b/src/mainboard/amd/lamar/mainboard.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_def.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <northbridge/amd/pi/00630F01/pci_devs.h> diff --git a/src/mainboard/amd/lamar/romstage.c b/src/mainboard/amd/lamar/romstage.c index a22b247..6471e11 100644 --- a/src/mainboard/amd/lamar/romstage.c +++ b/src/mainboard/amd/lamar/romstage.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/amd/olivehillplus/romstage.c b/src/mainboard/amd/olivehillplus/romstage.c index 3dd7d53..368b911 100644 --- a/src/mainboard/amd/olivehillplus/romstage.c +++ b/src/mainboard/amd/olivehillplus/romstage.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c index 0423837..6c649e0 100644 --- a/src/mainboard/apple/macbook21/mainboard.c +++ b/src/mainboard/apple/macbook21/mainboard.c @@ -16,7 +16,6 @@ */
#include <device/device.h> -#include <device/pci_def.h> #include <northbridge/intel/i945/i945.h> #include <arch/acpigen.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c index 5b3a30b..038e5ed 100644 --- a/src/mainboard/asus/p2b-ds/romstage.c +++ b/src/mainboard/asus/p2b-ds/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c index f933c77..a4f1671 100644 --- a/src/mainboard/asus/p2b-ls/romstage.c +++ b/src/mainboard/asus/p2b-ls/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c index 1d7c928..805fc94 100644 --- a/src/mainboard/asus/p2b/romstage.c +++ b/src/mainboard/asus/p2b/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c index 8fc135d..e9630bf 100644 --- a/src/mainboard/asus/p3b-f/romstage.c +++ b/src/mainboard/asus/p3b-f/romstage.c @@ -15,7 +15,6 @@ */
#include <arch/io.h> -#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/bap/ode_e21XX/mainboard.c b/src/mainboard/bap/ode_e21XX/mainboard.c index 00ac1a4..68e3e92 100644 --- a/src/mainboard/bap/ode_e21XX/mainboard.c +++ b/src/mainboard/bap/ode_e21XX/mainboard.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_def.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h>
diff --git a/src/mainboard/bap/ode_e21XX/romstage.c b/src/mainboard/bap/ode_e21XX/romstage.c index 9729ffb..132024e 100644 --- a/src/mainboard/bap/ode_e21XX/romstage.c +++ b/src/mainboard/bap/ode_e21XX/romstage.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c index 813b1d6..5f528ed 100644 --- a/src/mainboard/getac/p470/mainboard.c +++ b/src/mainboard/getac/p470/mainboard.c @@ -15,7 +15,6 @@ */
#include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <delay.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/gizmosphere/gizmo/mainboard.c b/src/mainboard/gizmosphere/gizmo/mainboard.c index 8196922..b65f56b 100644 --- a/src/mainboard/gizmosphere/gizmo/mainboard.c +++ b/src/mainboard/gizmosphere/gizmo/mainboard.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h>
diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c index e6cc01f..bbac6ec 100644 --- a/src/mainboard/google/beltino/mainboard.c +++ b/src/mainboard/google/beltino/mainboard.c @@ -18,7 +18,6 @@ #include <arch/acpi.h> #include <arch/io.h> #include <device/device.h> -#include <device/pci_def.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index b5f96b4..b52351b 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <cbfs.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/google/link/early_init.c b/src/mainboard/google/link/early_init.c index 8c58054..19cd295 100644 --- a/src/mainboard/google/link/early_init.c +++ b/src/mainboard/google/link/early_init.c @@ -18,7 +18,6 @@ #include <string.h> #include <device/pci_ops.h> #include <device/pci.h> -#include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <arch/acpi.h> #include <console/console.h> diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c index a91930b..21274b34 100644 --- a/src/mainboard/google/link/mainboard.c +++ b/src/mainboard/google/link/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #if CONFIG(VGA_ROM_RUN) diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c index 361215a..5f47c05 100644 --- a/src/mainboard/google/parrot/mainboard.c +++ b/src/mainboard/google/parrot/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c index 64dc99f..d4e38d0 100644 --- a/src/mainboard/google/rambi/mainboard.c +++ b/src/mainboard/google/rambi/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <console/console.h> #if CONFIG(VGA_ROM_RUN) #include <x86emu/x86emu.h> diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c index 4c50ea6..5a1af73 100644 --- a/src/mainboard/google/slippy/mainboard.c +++ b/src/mainboard/google/slippy/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <smbios.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 782546a..2d4086a 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c index 37af13f..ca93d31 100644 --- a/src/mainboard/intel/baskingridge/mainboard.c +++ b/src/mainboard/intel/baskingridge/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/intel/d510mo/mainboard.c b/src/mainboard/intel/d510mo/mainboard.c index cac5064..f90ee89 100644 --- a/src/mainboard/intel/d510mo/mainboard.c +++ b/src/mainboard/intel/d510mo/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <device/pci_def.h> #include <device/pci.h> #include <drivers/intel/gma/int15.h>
diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c index 210588c..2f09a78 100644 --- a/src/mainboard/intel/emeraldlake2/mainboard.c +++ b/src/mainboard/intel/emeraldlake2/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c index ce16815..8ce494b 100644 --- a/src/mainboard/intel/wtm2/mainboard.c +++ b/src/mainboard/intel/wtm2/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index b3e8427..fcf43e1 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -16,7 +16,6 @@ #include <string.h> #include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <console/console.h> #include <drivers/intel/gma/int15.h> #include <pc80/mc146818rtc.h> diff --git a/src/mainboard/lenovo/s230u/early_init.c b/src/mainboard/lenovo/s230u/early_init.c index 2de0637..10ce300 100644 --- a/src/mainboard/lenovo/s230u/early_init.c +++ b/src/mainboard/lenovo/s230u/early_init.c @@ -17,7 +17,6 @@ #include <string.h> #include <cbfs.h> #include <device/pci_ops.h> -#include <device/pci_def.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c index 3f62f06..fa6028d 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c +++ b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c @@ -16,7 +16,6 @@ */
#include <option.h> -#include <device/pci_def.h> #include <console/console.h> #include <cbfs.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c index 5f59946..93cad77 100644 --- a/src/mainboard/lenovo/t60/mainboard.c +++ b/src/mainboard/lenovo/t60/mainboard.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <arch/io.h> #include <device/device.h> #include <ec/lenovo/pmh7/pmh7.h> diff --git a/src/mainboard/lippert/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/mainboard.c index ea473c0..8fe83c5 100644 --- a/src/mainboard/lippert/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/mainboard.c @@ -21,7 +21,6 @@ #include <arch/io.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <device/pci_def.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <vendorcode/amd/cimx/sb800/OEM.h> /* SMBUS0_BASE_ADDRESS */ #include <southbridge/amd/cimx/sb800/gpio_oem.h> diff --git a/src/mainboard/lippert/toucan-af/mainboard.c b/src/mainboard/lippert/toucan-af/mainboard.c index b000688..3e842bd 100644 --- a/src/mainboard/lippert/toucan-af/mainboard.c +++ b/src/mainboard/lippert/toucan-af/mainboard.c @@ -20,7 +20,6 @@ #include <device/pci.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <device/pci_def.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <vendorcode/amd/cimx/sb800/OEM.h> /* SMBUS0_BASE_ADDRESS */ #include <southbridge/amd/cimx/sb800/gpio_oem.h> diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index f64e9e3..56a50bf 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -18,7 +18,6 @@
#include <device/device.h> #include <arch/io.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <northbridge/intel/nehalem/nehalem.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/samsung/lumpy/mainboard.c b/src/mainboard/samsung/lumpy/mainboard.c index c64a51b..e28e0d8 100644 --- a/src/mainboard/samsung/lumpy/mainboard.c +++ b/src/mainboard/samsung/lumpy/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <string.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <ec/smsc/mec1308/ec.h> diff --git a/src/mainboard/supermicro/x10slm-f/mainboard.c b/src/mainboard/supermicro/x10slm-f/mainboard.c index 4bd5d15..56674b9 100644 --- a/src/mainboard/supermicro/x10slm-f/mainboard.c +++ b/src/mainboard/supermicro/x10slm-f/mainboard.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci_def.h> #include <option.h> #include <stdint.h> #include <types.h>
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37688
to look at the new patch set (#2).
Change subject: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h> ......................................................................
mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h>
Change-Id: I4dcdcb734e20830ac97d4a826de61017afc6ee67 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/bettong/BiosCallOuts.c M src/mainboard/amd/db-ft3b-lc/romstage.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/lamar/romstage.c M src/mainboard/amd/olivehillplus/romstage.c M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/getac/p470/mainboard.c M src/mainboard/gizmosphere/gizmo/mainboard.c M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/link/early_init.c M src/mainboard/google/link/mainboard.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/google/stout/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c M src/mainboard/intel/d510mo/mainboard.c M src/mainboard/intel/emeraldlake2/mainboard.c M src/mainboard/intel/wtm2/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/early_init.c M src/mainboard/lenovo/t430s/variants/t431s/romstage.c M src/mainboard/lenovo/t60/mainboard.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x201/romstage.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/packardbell/ms2290/romstage.c M src/mainboard/samsung/lumpy/mainboard.c M src/mainboard/supermicro/x10slm-f/mainboard.c 38 files changed, 0 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37688/2
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37688
to look at the new patch set (#3).
Change subject: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h> ......................................................................
mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h>
Change-Id: I4dcdcb734e20830ac97d4a826de61017afc6ee67 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/getac/p470/mainboard.c M src/mainboard/gizmosphere/gizmo/mainboard.c M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/link/early_init.c M src/mainboard/google/link/mainboard.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/google/stout/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c M src/mainboard/intel/d510mo/mainboard.c M src/mainboard/intel/emeraldlake2/mainboard.c M src/mainboard/intel/wtm2/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/early_init.c M src/mainboard/lenovo/t430s/variants/t431s/romstage.c M src/mainboard/lenovo/t60/mainboard.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/packardbell/ms2290/romstage.c M src/mainboard/samsung/lumpy/mainboard.c M src/mainboard/supermicro/x10slm-f/mainboard.c 29 files changed, 0 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37688/3
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37688 )
Change subject: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h> ......................................................................
Patch Set 3: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37688 )
Change subject: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h> ......................................................................
Patch Set 3: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37688 )
Change subject: mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h> ......................................................................
mb/*/{BiosCallOuts,mainboard,romstage}.c: Remove unused <device/pci_{def,ops}.h>
Change-Id: I4dcdcb734e20830ac97d4a826de61017afc6ee67 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37688 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/apple/macbook21/mainboard.c M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/getac/p470/mainboard.c M src/mainboard/gizmosphere/gizmo/mainboard.c M src/mainboard/google/beltino/mainboard.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/link/early_init.c M src/mainboard/google/link/mainboard.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/slippy/mainboard.c M src/mainboard/google/stout/mainboard.c M src/mainboard/intel/baskingridge/mainboard.c M src/mainboard/intel/d510mo/mainboard.c M src/mainboard/intel/emeraldlake2/mainboard.c M src/mainboard/intel/wtm2/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/early_init.c M src/mainboard/lenovo/t430s/variants/t431s/romstage.c M src/mainboard/lenovo/t60/mainboard.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/packardbell/ms2290/romstage.c M src/mainboard/samsung/lumpy/mainboard.c M src/mainboard/supermicro/x10slm-f/mainboard.c 29 files changed, 0 insertions(+), 30 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c index 0423837..6c649e0 100644 --- a/src/mainboard/apple/macbook21/mainboard.c +++ b/src/mainboard/apple/macbook21/mainboard.c @@ -16,7 +16,6 @@ */
#include <device/device.h> -#include <device/pci_def.h> #include <northbridge/intel/i945/i945.h> #include <arch/acpigen.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c index 5b3a30b..038e5ed 100644 --- a/src/mainboard/asus/p2b-ds/romstage.c +++ b/src/mainboard/asus/p2b-ds/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c index f933c77..a4f1671 100644 --- a/src/mainboard/asus/p2b-ls/romstage.c +++ b/src/mainboard/asus/p2b-ls/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c index 1d7c928..805fc94 100644 --- a/src/mainboard/asus/p2b/romstage.c +++ b/src/mainboard/asus/p2b/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c index 8fc135d..e9630bf 100644 --- a/src/mainboard/asus/p3b-f/romstage.c +++ b/src/mainboard/asus/p3b-f/romstage.c @@ -15,7 +15,6 @@ */
#include <arch/io.h> -#include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c index da90349..c20da65 100644 --- a/src/mainboard/getac/p470/mainboard.c +++ b/src/mainboard/getac/p470/mainboard.c @@ -15,7 +15,6 @@ */
#include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <drivers/intel/gma/int15.h>
diff --git a/src/mainboard/gizmosphere/gizmo/mainboard.c b/src/mainboard/gizmosphere/gizmo/mainboard.c index 8196922..b65f56b 100644 --- a/src/mainboard/gizmosphere/gizmo/mainboard.c +++ b/src/mainboard/gizmosphere/gizmo/mainboard.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h>
diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c index e6cc01f..bbac6ec 100644 --- a/src/mainboard/google/beltino/mainboard.c +++ b/src/mainboard/google/beltino/mainboard.c @@ -18,7 +18,6 @@ #include <arch/acpi.h> #include <arch/io.h> #include <device/device.h> -#include <device/pci_def.h> #include <southbridge/intel/lynxpoint/pch.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index b5f96b4..b52351b 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <cbfs.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/google/link/early_init.c b/src/mainboard/google/link/early_init.c index 8c58054..19cd295 100644 --- a/src/mainboard/google/link/early_init.c +++ b/src/mainboard/google/link/early_init.c @@ -18,7 +18,6 @@ #include <string.h> #include <device/pci_ops.h> #include <device/pci.h> -#include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <arch/acpi.h> #include <console/console.h> diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c index a91930b..21274b34 100644 --- a/src/mainboard/google/link/mainboard.c +++ b/src/mainboard/google/link/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #if CONFIG(VGA_ROM_RUN) diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c index 361215a..5f47c05 100644 --- a/src/mainboard/google/parrot/mainboard.c +++ b/src/mainboard/google/parrot/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c index 64dc99f..d4e38d0 100644 --- a/src/mainboard/google/rambi/mainboard.c +++ b/src/mainboard/google/rambi/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <console/console.h> #if CONFIG(VGA_ROM_RUN) #include <x86emu/x86emu.h> diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c index 4c50ea6..5a1af73 100644 --- a/src/mainboard/google/slippy/mainboard.c +++ b/src/mainboard/google/slippy/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <smbios.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 782546a..2d4086a 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <device/pci_ops.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c index 37af13f..ca93d31 100644 --- a/src/mainboard/intel/baskingridge/mainboard.c +++ b/src/mainboard/intel/baskingridge/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/intel/d510mo/mainboard.c b/src/mainboard/intel/d510mo/mainboard.c index cac5064..f90ee89 100644 --- a/src/mainboard/intel/d510mo/mainboard.c +++ b/src/mainboard/intel/d510mo/mainboard.c @@ -14,7 +14,6 @@ */
#include <device/device.h> -#include <device/pci_def.h> #include <device/pci.h> #include <drivers/intel/gma/int15.h>
diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c index 210588c..2f09a78 100644 --- a/src/mainboard/intel/emeraldlake2/mainboard.c +++ b/src/mainboard/intel/emeraldlake2/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c index ce16815..8ce494b 100644 --- a/src/mainboard/intel/wtm2/mainboard.c +++ b/src/mainboard/intel/wtm2/mainboard.c @@ -16,7 +16,6 @@
#include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index b3e8427..fcf43e1 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -16,7 +16,6 @@ #include <string.h> #include <types.h> #include <device/device.h> -#include <device/pci_def.h> #include <console/console.h> #include <drivers/intel/gma/int15.h> #include <pc80/mc146818rtc.h> diff --git a/src/mainboard/lenovo/s230u/early_init.c b/src/mainboard/lenovo/s230u/early_init.c index 2de0637..10ce300 100644 --- a/src/mainboard/lenovo/s230u/early_init.c +++ b/src/mainboard/lenovo/s230u/early_init.c @@ -17,7 +17,6 @@ #include <string.h> #include <cbfs.h> #include <device/pci_ops.h> -#include <device/pci_def.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c index 3f62f06..fa6028d 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/romstage.c +++ b/src/mainboard/lenovo/t430s/variants/t431s/romstage.c @@ -16,7 +16,6 @@ */
#include <option.h> -#include <device/pci_def.h> #include <console/console.h> #include <cbfs.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c index 5f59946..93cad77 100644 --- a/src/mainboard/lenovo/t60/mainboard.c +++ b/src/mainboard/lenovo/t60/mainboard.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <device/pci_def.h> #include <arch/io.h> #include <device/device.h> #include <ec/lenovo/pmh7/pmh7.h> diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c index a403237..4cd3bde 100644 --- a/src/mainboard/lenovo/x201/mainboard.c +++ b/src/mainboard/lenovo/x201/mainboard.c @@ -17,7 +17,6 @@ */
#include <device/device.h> -#include <device/pci_ops.h> #include <ec/acpi/ec.h> #include <northbridge/intel/nehalem/nehalem.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c index c8e8afb..7bab957 100644 --- a/src/mainboard/lenovo/x201/romstage.c +++ b/src/mainboard/lenovo/x201/romstage.c @@ -18,7 +18,6 @@
#include <stdint.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <ec/acpi/ec.h>
#include <southbridge/intel/ibexpeak/pch.h> diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index f64e9e3..d4e48bc 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -18,8 +18,6 @@
#include <device/device.h> #include <arch/io.h> -#include <device/pci_def.h> -#include <device/pci_ops.h> #include <northbridge/intel/nehalem/nehalem.h> #include <southbridge/intel/bd82x6x/pch.h> #include <ec/acpi/ec.h> diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c index 4d94329..1f9d229 100644 --- a/src/mainboard/packardbell/ms2290/romstage.c +++ b/src/mainboard/packardbell/ms2290/romstage.c @@ -17,7 +17,6 @@ */
#include <stdint.h> -#include <device/pci_ops.h>
#include <southbridge/intel/ibexpeak/pch.h> #include <northbridge/intel/nehalem/nehalem.h> diff --git a/src/mainboard/samsung/lumpy/mainboard.c b/src/mainboard/samsung/lumpy/mainboard.c index c64a51b..e28e0d8 100644 --- a/src/mainboard/samsung/lumpy/mainboard.c +++ b/src/mainboard/samsung/lumpy/mainboard.c @@ -17,7 +17,6 @@ #include <types.h> #include <string.h> #include <device/device.h> -#include <device/pci_def.h> #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <ec/smsc/mec1308/ec.h> diff --git a/src/mainboard/supermicro/x10slm-f/mainboard.c b/src/mainboard/supermicro/x10slm-f/mainboard.c index 4bd5d15..56674b9 100644 --- a/src/mainboard/supermicro/x10slm-f/mainboard.c +++ b/src/mainboard/supermicro/x10slm-f/mainboard.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci_def.h> #include <option.h> #include <stdint.h> #include <types.h>
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)