Change in coreboot[master]: drivers/usb/acpi: Avoid dereferencing maybe-NULL pointer - coreboot-gerrit

13 Jul 2021


      Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56266 )
Change subject: drivers/usb/acpi: Avoid dereferencing maybe-NULL pointer
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56266/comment/39033758_ec22b0d2 
PS1, Line 132: struct drivers_usb_acpi_config *config
nit: I would rather keep this declared up top.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56266
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbe9ae99d91fd587d8e56cf3a0dcb59834ee6d07
Gerrit-Change-Number: 56266
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 17:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment