Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: acpi: Add support for reporting CrashLog in BERT table
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Starting next week I will be out of office for about 2 months and won't be available to review patch […]
i have pushed a patch train that unifies the AMD and Intel BERT flow: https://review.coreboot.org/c/coreboot/+/54149/4 is the top of that patch train; would be great if you could test that this doesn't break your platform; i'm rather confident that it won't change behaviour, since it mostly moves some bits of code around.
I'm still not sure if there's something off with the raw_data_* struct elements, but at least now the linux kernel doesn't fail to decode the bert region. Not sure if/when i'll get to the bottom of that, but at least the code is in a better shape now.
Enjoy your vacation!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00e390d735d61beac2e89a726e39119d9b06b3df
Gerrit-Change-Number: 49799
Gerrit-PatchSet: 10
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikunj Dadhania
nikunj.dadhania@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Fri, 28 May 2021 15:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-MessageType: comment