[L] Change in coreboot[main]: mb/intel/avenuecity_crb: Add GNR/SRF-AP 2S server board Avenue City

[Shuo Liu (Code Review)]

Attention is currently required from: Arthur Heymans, Chen, Gang C, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, Paul Menzel, TangYiwei, Varshit Pandya.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email )

Change subject: mb/intel/avenuecity_crb: Add GNR/SRF-AP 2S server board Avenue City
......................................................................

Patch Set 37:

(3 comments)

File src/mainboard/intel/avenuecity_crb/config/iio.c:

https://review.coreboot.org/c/coreboot/+/81319/comment/10405c57_4469de9a :
PS35, Line 5: const
> static

Done

File src/mainboard/intel/avenuecity_crb/config/iio.c:

https://review.coreboot.org/c/coreboot/+/81319/comment/2c0da0e8_be4dd256 :
PS36, Line 14: _IIO_PORT_CFG_STRUCT_X8(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
             : 				0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x1),
             : 		_IIO_PORT_CFG_STRUCT_DISABLED,
             : 		_IIO_PORT_CFG_STRUCT_DISABLED,
             : 		_IIO_PORT_CFG_STRUCT_DISABLED,
             : 		_IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
             : 				0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x2),
             : 		_IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
             : 				0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x3),
             : 		_IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
             : 				0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x4),
             : 		_IIO_PORT_CFG_STRUCT_X2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
             : 				0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x4B, 0x5)
> Does the order of these matter? If not not maybe align the used ones to the top of the array, set th […]

Yes, they matters. The minimal port elements are x2. If an x8 port is enabled, the neighboring 4 x2 port elements needs to be disabled. Here in the setting, IIO_BIFURCATE_x2x2x2x2x8 is first set to indicate how the IIO is bifurcated, then port settings are listed accordingly.

P.S. x2x2x2x2x8 are actually enforced from right to left, x8 is first set.

File src/mainboard/intel/avenuecity_crb/include/config/iio.h:

https://review.coreboot.org/c/coreboot/+/81319/comment/e93d00a0_3d17336e :
PS31, Line 12: _IIO_PORT_CFG_STRUCT(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
             : 				0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0),
> > In this basic example it should be no problem. […]

Good idea, updated