Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36925 )
Change subject: mb/google/octopus: Disable fmap cache output for meep ......................................................................
mb/google/octopus: Disable fmap cache output for meep
This makes the cros default config build again.
Change-Id: I52c0c30a14929913ded144bf086c12938e9c2699 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/octopus/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/36925/1
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index f67f642..cdfab61 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -129,4 +129,8 @@ default 1 if BOARD_GOOGLE_MEEP default 255 if BOARD_GOOGLE_OCTOPUS
+config SILENT_FMAP_CACHE + bool + default y if BOARD_GOOGLE_MEEP + endif # BOARD_GOOGLE_OCTOPUS
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36925 )
Change subject: mb/google/octopus: Disable fmap cache output for meep ......................................................................
Patch Set 1: Code-Review+1
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36925
to look at the new patch set (#2).
Change subject: mb/google/octopus: Disable fmap cache for meep ......................................................................
mb/google/octopus: Disable fmap cache for meep
This makes the cros default config build again.
Change-Id: I52c0c30a14929913ded144bf086c12938e9c2699 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/octopus/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/36925/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36925 )
Change subject: mb/google/octopus: Disable fmap cache for meep ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36925/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36925/2//COMMIT_MSG@9 PS2, Line 9: This makes the cros default config build again. Is this about code size? Please mention why it fixes things.
Hello TungYang Huang, Chen Wisley, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36925
to look at the new patch set (#3).
Change subject: mb/google/octopus: Disable fmap cache for meep ......................................................................
mb/google/octopus: Disable fmap cache for meep
By removing this code, we get approximately back to where the board was before the fmap cache feature was added, which is small enough for the Chromium OS default configuration for the board to fit into the 32KB that the bootblock can use on the chipset again.
Change-Id: I52c0c30a14929913ded144bf086c12938e9c2699 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/octopus/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/36925/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36925 )
Change subject: mb/google/octopus: Disable fmap cache for meep ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36925/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36925/2//COMMIT_MSG@9 PS2, Line 9: This makes the cros default config build again.
Is this about code size? Please mention why it fixes things.
Done. I'm not sure why only meep is affected, but that's where we are...
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36925 )
Change subject: mb/google/octopus: Disable fmap cache for meep ......................................................................
mb/google/octopus: Disable fmap cache for meep
By removing this code, we get approximately back to where the board was before the fmap cache feature was added, which is small enough for the Chromium OS default configuration for the board to fit into the 32KB that the bootblock can use on the chipset again.
Change-Id: I52c0c30a14929913ded144bf086c12938e9c2699 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36925 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/octopus/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index f67f642..d712600 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -22,6 +22,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 select GOOGLE_SMBIOS_MAINBOARD_VERSION + select NO_FMAP_CACHE if BOARD_GOOGLE_MEEP
if BOARD_GOOGLE_BASEBOARD_OCTOPUS
-
Nico Huber (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)