Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58765 )
Change subject: amdfwtool: Change the definition of level to a bitwise form ......................................................................
amdfwtool: Change the definition of level to a bitwise form
Change-Id: Icca393f0d69519cc1c3cb852a11dd7006cf72061 Signed-off-by: Zheng Bao fishbaozi@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/58765 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/amdfwtool/amdfwtool.h 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index d7f0f5d..b37503e 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -182,8 +182,8 @@ bios_directory_entry entries[]; } bios_directory_table;
-#define BDT_LVL1 0x1 -#define BDT_LVL2 0x2 +#define BDT_LVL1 (1 << 0) +#define BDT_LVL2 (1 << 1) #define BDT_BOTH (BDT_LVL1 | BDT_LVL2) typedef struct _amd_bios_entry { amd_bios_type type; @@ -208,8 +208,8 @@ #define BDT1_COOKIE 0x44484224 /* 'DHB$ */ #define BDT2_COOKIE 0x324c4224 /* '2LB$ */
-#define PSP_LVL1 0x1 -#define PSP_LVL2 0x2 +#define PSP_LVL1 (1 << 0) +#define PSP_LVL2 (1 << 1) #define PSP_BOTH (PSP_LVL1 | PSP_LVL2) typedef struct _amd_fw_entry { amd_fw_type type;