Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36506 )
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
mb/facebook/fbg1701: Add logo to the menu
Allow the user to enable and disable the logo from make menuconfig. The file can ve selected as well.
BUG=N/A TEST=build
Change-Id: I630a9d14308131c180adaaa9e1fa5e6e11c3c61c Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36506/1
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index a6c2846..3ade727 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -69,9 +69,14 @@ default 0xfff9c000
config FSP1_1_DISPLAY_LOGO - bool + bool "Enable logo" default n
+config FSP1_1_LOGO_FILE_NAME + string "Logo file" + depends on FSP1_1_DISPLAY_LOGO + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/logo.bmp" + config VENDORCODE_ELTAN_OEM_MANIFEST_LOC hex default 0xFFFE9000
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36506
to look at the new patch set (#2).
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
mb/facebook/fbg1701: Add logo to the menu
Allow the user to enable and disable the logo from make menuconfig. The file can be selected as well.
BUG=N/A TEST=build
Change-Id: I630a9d14308131c180adaaa9e1fa5e6e11c3c61c Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36506/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36506 )
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36506 )
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36506/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/36506/2/src/mainboard/facebook/fbg1... PS2, Line 73: default n Why is this in the mainboard Kconfig, and not the chipset one?
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36506 )
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36506/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/36506/2/src/mainboard/facebook/fbg1... PS2, Line 73: default n
Why is this in the mainboard Kconfig, and not the chipset one?
The actual code to provide logo to the fsp is also in this directory. This is the only place where the config items are declared. This is the only board using this support so moving the complete support to the FSP 1.1 driver doesn't make a whole lot of sense.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36506 )
Change subject: mb/facebook/fbg1701: Add logo to the menu ......................................................................
mb/facebook/fbg1701: Add logo to the menu
Allow the user to enable and disable the logo from make menuconfig. The file can be selected as well.
BUG=N/A TEST=build
Change-Id: I630a9d14308131c180adaaa9e1fa5e6e11c3c61c Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36506 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index a6c2846..3ade727 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -69,9 +69,14 @@ default 0xfff9c000
config FSP1_1_DISPLAY_LOGO - bool + bool "Enable logo" default n
+config FSP1_1_LOGO_FILE_NAME + string "Logo file" + depends on FSP1_1_DISPLAY_LOGO + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/logo.bmp" + config VENDORCODE_ELTAN_OEM_MANIFEST_LOC hex default 0xFFFE9000
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)